Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debian: Re-enable build of MythNetVision #161

Open
rcrdnalor opened this issue Jul 21, 2023 · 3 comments
Open

Debian: Re-enable build of MythNetVision #161

rcrdnalor opened this issue Jul 21, 2023 · 3 comments

Comments

@rcrdnalor
Copy link
Contributor

rcrdnalor commented Jul 21, 2023

This patch is for reference only.
Ubuntu decided years ago to disable the build of MythNetVision.
In case one decides to re-enable it, the following patch enables
the build of MythNetVision on Ubuntu again.
It does not package this plugin, though.

The patch needs the package python3-pip and the removal of the
package python3-distutils, which is done in python3.12, anyway.
It only works on Ubuntu 22.04+ because of missing functionality
prior to python 3.10.

It needs MythTV#437
to be solved beforehand.

diff --git a/deb/debian/rules b/deb/debian/rules
index ba79718e..37a6f073 100755
--- a/deb/debian/rules
+++ b/deb/debian/rules
@@ -119,11 +119,11 @@ override_dh_auto_install:
 	$(MAKE) -C mythtv install INSTALL_ROOT=$(CURDIR)/debian/tmp
 
 	#mythplugins
-	cd mythplugins && ./configure $(MYTHPLUGINS_CONFIGURE_OPTS) --mythroot=$(CURDIR)/debian/tmp:$(CURDIR)/debian/libmyth-python
+	cd mythplugins && DEB_PYTHON_INSTALL_LAYOUT=deb_system ./configure $(MYTHPLUGINS_CONFIGURE_OPTS) --mythroot=$(CURDIR)/debian/tmp:$(CURDIR)/debian/libmyth-python
 	$(MAKE) -j$(PROCESSORS) -C mythplugins
 	for plugin in mytharchive \
 	mythgame mythmusic mythnews \
-	mythweather mythzoneminder mythbrowser ; do \
+	mythweather mythzoneminder mythbrowser mythnetvision ; do \
 		$(MAKE) -C mythplugins/$$plugin install INSTALL_ROOT=$(CURDIR)/debian/$$plugin; \
 	done

Attached packaging_deb_mythnetvision.zip

@superm1
Copy link
Member

superm1 commented Aug 6, 2023

If it needs pip - does that mean that it mean it downloads things dynamically? If so; we should instead be having dependencies for the things it gets from pip in debian/control.

@rcrdnalor
Copy link
Contributor Author

No, pip does not download dependencies automatically.
See 5852297 which works on master.
I do not recommend to re-enable this plugin for Ubuntu, though.
This issue is just for reference, once this plugin is maintained again.

@superm1
Copy link
Member

superm1 commented Aug 6, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants