Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PULL_REQUEST_TEMPLATE.md #486

Merged
merged 3 commits into from
Nov 11, 2024
Merged

Update PULL_REQUEST_TEMPLATE.md #486

merged 3 commits into from
Nov 11, 2024

Conversation

aboydnw
Copy link
Contributor

@aboydnw aboydnw commented Nov 7, 2024

The PR template seems a little outdated, so updating with some checklists of frequent items that come up during reviews.

The PR template seems a little outdated, so updating with some checklists of frequent items that come up during reviews.
Copy link

netlify bot commented Nov 7, 2024

Deploy Preview for visex ready!

Name Link
🔨 Latest commit 2342140
🔍 Latest deploy log https://app.netlify.com/sites/visex/deploys/6731b3b0c970230008ffaa83
😎 Deploy Preview https://deploy-preview-486--visex.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

- [ ] Any images are compressed, ideally <500 KB
- [ ] Published Date is as close to the actual release date as possible (work with veda-ui team to determine potential release date when story is close to ready)
- [ ] At least one code owner has reviewed the PR
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a third one for when we only pull-in the latest veda-ui updates?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dzole0311 I like that idea! I'm not very familiar with that process though. Would you or @sandrahoang686 @hanbyul-here be able to suggest a checklist?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oki I took a stab and pushed the change. (I also edited the doc about updating veda-ui) Let me know how it looks!

@hanbyul-here
Copy link
Collaborator

hanbyul-here commented Nov 11, 2024

I have a question - did you list out the possible options on purpose? Currently, the PR asks you what kind of change you are making and takes you to the right template - Your approach can save a click so I don't really mind the change, but I just wanted to confirm if this was intentional (If so, we need to delete the files in the folder https://github.com/US-GHG-Center/veda-config-ghg/tree/develop/.github/PULL_REQUEST_TEMPLATE )

@dzole0311 dzole0311 self-requested a review November 11, 2024 07:35
@aboydnw
Copy link
Contributor Author

aboydnw commented Nov 11, 2024

@hanbyul-here the PR template you linked to is in veda-config-ghg. I don't think we have the same template(s) for veda-config. Maybe it's just about pulling over those PR templates? If they work better, I'm open to doing that too.

@aboydnw
Copy link
Contributor Author

aboydnw commented Nov 11, 2024

I'll go ahead and merge this PR and we can update the template again based on what we want to do with the veda-config-ghg template

@aboydnw aboydnw merged commit dd2e80c into develop Nov 11, 2024
6 checks passed
@aboydnw aboydnw deleted the update-pr-template branch November 11, 2024 19:40
@hanbyul-here
Copy link
Collaborator

@aboydnw Urg sorry, I meant these files : https://github.com/NASA-IMPACT/veda-config/tree/develop/.github/PULL_REQUEST_TEMPLATE
I really do not have a good idea if just removing the unrelated parts is more convenient for users or clicking to the specific one is better. But we just need to be coherent (if we are making a user to delete unrealted parts, remove the files in PULL_REQUEST_TEMPLATE, if we want a user to follow the previous workflow, split the current contents into each template and retrieve the previous links)

@aboydnw aboydnw mentioned this pull request Nov 12, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants