-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PULL_REQUEST_TEMPLATE.md #486
Conversation
The PR template seems a little outdated, so updating with some checklists of frequent items that come up during reviews.
✅ Deploy Preview for visex ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
- [ ] Any images are compressed, ideally <500 KB | ||
- [ ] Published Date is as close to the actual release date as possible (work with veda-ui team to determine potential release date when story is close to ready) | ||
- [ ] At least one code owner has reviewed the PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a third one for when we only pull-in the latest veda-ui
updates?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dzole0311 I like that idea! I'm not very familiar with that process though. Would you or @sandrahoang686 @hanbyul-here be able to suggest a checklist?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oki I took a stab and pushed the change. (I also edited the doc about updating veda-ui) Let me know how it looks!
I have a question - did you list out the possible options on purpose? Currently, the PR asks you what kind of change you are making and takes you to the right template - Your approach can save a click so I don't really mind the change, but I just wanted to confirm if this was intentional (If so, we need to delete the files in the folder https://github.com/US-GHG-Center/veda-config-ghg/tree/develop/.github/PULL_REQUEST_TEMPLATE ) |
@hanbyul-here the PR template you linked to is in veda-config-ghg. I don't think we have the same template(s) for veda-config. Maybe it's just about pulling over those PR templates? If they work better, I'm open to doing that too. |
I'll go ahead and merge this PR and we can update the template again based on what we want to do with the veda-config-ghg template |
@aboydnw Urg sorry, I meant these files : https://github.com/NASA-IMPACT/veda-config/tree/develop/.github/PULL_REQUEST_TEMPLATE |
The PR template seems a little outdated, so updating with some checklists of frequent items that come up during reviews.