Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup Is2 harmony notebook #365

Merged
merged 11 commits into from
Nov 7, 2024
Merged

Fixup Is2 harmony notebook #365

merged 11 commits into from
Nov 7, 2024

Conversation

andypbarrett
Copy link
Contributor

The IS2 Harmony notebook that describes how to subset ICESat-2 granules using harmony had been modified.

Make tutorial steps sequentials by removing extra information to appendices
Modify text and remove unnecessary print statements - Jupyter will output results etc without a print statement
Add image to show subset area of interest
Add large order guidance to Appendix

@andypbarrett andypbarrett linked an issue Oct 31, 2024 that may be closed by this pull request
@asteiker
Copy link
Contributor

asteiker commented Nov 1, 2024

@andypbarrett I pushed up a few updates and comments in italics. Overall this is looking great. I didn't open a review yet - perhaps you could address my initial comments and then I can do one more review to move out of draft PR state? I recommended a few areas that we could pull out into a version 2, including much of the appendix section and "choose my own s3 bucket" use case.

I also had some issues with xarray but I think this is a "me" problem - I was installing another library and it may have messed with my kernel. Lmk if you can reproduce, otherwise ignore.

@andypbarrett
Copy link
Contributor Author

I'll take a look at this before standup and get it ready for review.

@andypbarrett andypbarrett marked this pull request as ready for review November 5, 2024 21:10
@jules32
Copy link
Contributor

jules32 commented Nov 7, 2024

Looks really great @asteiker and @andypbarrett ! We discussed/screenshared today with @asteiker and @danielfromearth. Amy has some notes about how to frame this as "subsetting with harmony" tutorial, using ICESAT2 data. And here is an example with TEMPO data: https://nasa.github.io/ASDC_Data_and_User_Services/TEMPO/tempo_with_harmony-py_clean.html

Copy link

github-actions bot commented Nov 7, 2024

@github-actions github-actions bot temporarily deployed to pull request November 7, 2024 18:57 Inactive
@ateucher
Copy link
Member

ateucher commented Nov 7, 2024

Hi all, I hope you don't mind my unsolicited appearance here! I came by to see if the deploy preview was working (yay, it is!), and I noticed the addition of tutorials/make_atl03_figure.ipynb (preview at https://deploy-preview-365--super-malabi-c81e61.netlify.app/tutorials/make_atl03_figure). Is this a page that should be added to the tutorials section of _quarto.yml?

Copy link

github-actions bot commented Nov 7, 2024

@asteiker asteiker merged commit c844cac into main Nov 7, 2024
2 checks passed
@asteiker asteiker deleted the is2-harmony branch November 8, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ICESat-2 Harmony subsetting guidance as new Tutorial
4 participants