-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixup Is2 harmony notebook #365
Conversation
@andypbarrett I pushed up a few updates and comments in italics. Overall this is looking great. I didn't open a review yet - perhaps you could address my initial comments and then I can do one more review to move out of draft PR state? I recommended a few areas that we could pull out into a version 2, including much of the appendix section and "choose my own s3 bucket" use case. I also had some issues with xarray but I think this is a "me" problem - I was installing another library and it may have messed with my kernel. Lmk if you can reproduce, otherwise ignore. |
I'll take a look at this before standup and get it ready for review. |
Looks really great @asteiker and @andypbarrett ! We discussed/screenshared today with @asteiker and @danielfromearth. Amy has some notes about how to frame this as "subsetting with harmony" tutorial, using ICESAT2 data. And here is an example with TEMPO data: https://nasa.github.io/ASDC_Data_and_User_Services/TEMPO/tempo_with_harmony-py_clean.html |
…, no need for jupyter specs
Hi all, I hope you don't mind my unsolicited appearance here! I came by to see if the deploy preview was working (yay, it is!), and I noticed the addition of |
The IS2 Harmony notebook that describes how to subset ICESat-2 granules using harmony had been modified.
Make tutorial steps sequentials by removing extra information to appendices
Modify text and remove unnecessary print statements - Jupyter will output results etc without a print statement
Add image to show subset area of interest
Add large order guidance to Appendix