Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find velocity in km/s #141

Open
2 of 3 tasks
detoma opened this issue Dec 13, 2023 · 1 comment
Open
2 of 3 tasks

Find velocity in km/s #141

detoma opened this issue Dec 13, 2023 · 1 comment
Assignees
Labels
enhancement New features of the pipeline level 2 Affects level2 products

Comments

@detoma
Copy link
Contributor

detoma commented Dec 13, 2023

To convert doppler shift to velocity in km/s, shall we use 1074.62 to 1074.70 to compute the conversion factor? This is the same conversion factor used for line width. It is a small difference but still, should look into that. I lean toward using the nominal wavelength for the line that is 1074.70 and is what we use in UCoMP.

@jburkepile Need Joan input on this.

We should not call comp_doppler_correction to compute the rest wavelength but the new method (still TBD) that uses east and west.

Questions

  • Is 1074.62 or 1074.70 the "nominal wavelength" for velocity and line width calculations? Use 1074.680 and 1079.795

Tasks

  • remove any calls to comp_doppler_correction
  • update "nominal wavelength" for 1074 in velocity and line width calculations
@mgalloy mgalloy self-assigned this Dec 13, 2023
@mgalloy mgalloy added this to the Decommissioning reprocessing milestone Dec 13, 2023
@mgalloy mgalloy added enhancement New features of the pipeline level 2 Affects level2 products labels Dec 13, 2023
@mgalloy mgalloy changed the title find velocity in Km/s Find velocity in km/s Dec 13, 2023
@mgalloy mgalloy added the questions Questions for instrument experts label Dec 13, 2023
@detoma
Copy link
Contributor Author

detoma commented Jan 29, 2024

This is a very small effect.

Let's use the nominal wavelength for the two lines in air as reported in Del Zanna & De Luca 2018 (based on Lyot measurements) and close the ticket:

1074.680

1079.795

@mgalloy mgalloy removed the questions Questions for instrument experts label Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features of the pipeline level 2 Affects level2 products
Projects
None yet
Development

No branches or pull requests

2 participants