You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Overall the paper is well written and easy to read. Except from a small remark below, the paper is fine for me.
However, the JOSS check list insists on two points Data sharing and Reproducibility. Are the tests presented in the paper available in the ngsPETSc sources or in the Firedrake sources ?
A small remark
The project has two seperate goals:
All PETSc solvers benefits from NETGEN meshes and geometries.
NGSolve users access to the wide array of linear, nonlinear solvers,
and time-steppers available in PETSc.
The first statement shall be more precise as only solvers based on DMPLEX seem able to benefit from ngsPETSc (example: Firedrake). There are many solvers that use PETSc but don't use DMPLEX as their mesh backends (example: FEniCS). In fact, the paper only focus on Firedrake which somehow further weakens the genericity of this first
statement.
I think that the first statement shall be more humble without making it less interesting. I may propose something like:
ngsPETSc seamlessly integrates with PETScDMPLEX, a feature that may benefit to any solver based in this solution. This paper illustrates this in the case of the Firedrake solver.
The text was updated successfully, but these errors were encountered:
Thank you for taking the time to review our manuscript.
All examples in the paper are either in the ngsPETSc documentation docs/src or in paper/examples. In particular all code for reproducing the results in the manuscript is in the ngsPETSc repository.
We agree that we should modify our first statement and we have implemented your suggestion in PR #66 .
Overall the paper is well written and easy to read. Except from a small remark below, the paper is fine for me.
However, the JOSS check list insists on two points Data sharing and Reproducibility. Are the tests presented in the paper available in the
ngsPETSc
sources or in theFiredrake
sources ?A small remark
The project has two seperate goals:
and time-steppers available in PETSc.
The first statement shall be more precise as only solvers based on
DMPLEX
seem able to benefit fromngsPETSc
(example:Firedrake
). There are many solvers that usePETSc
but don't useDMPLEX
as their mesh backends (example:FEniCS
). In fact, the paper only focus onFiredrake
which somehow further weakens the genericity of this firststatement.
I think that the first statement shall be more humble without making it less interesting. I may propose something like:
The text was updated successfully, but these errors were encountered: