-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Async mut-less Signer trait #161
Comments
This was referenced Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Async rationale: the synchronous or asynchronous nature of signer behaviour is implementation specific, e.g. it might be an HSM contacted over a network via the KMIP TCP+TLS protocol which involves waiting which ideally wouldn't be blocking.
Mut-less rationale: the granularity of locking is signer implementation dependent, taking the KMIP HSM example again the HSM will impose its own locking, from a client perspective the protocol is stateless and permits me to make multiple key creation or other requests in parallel but with
&mut
in theSigner
trait fns the caller is currently forced to lock all access to the Signer when using&mut
fn.The text was updated successfully, but these errors were encountered: