Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PSA: Great ReSeed happening at some point #2156

Open
scarlehoff opened this issue Sep 22, 2024 · 0 comments
Open

PSA: Great ReSeed happening at some point #2156

scarlehoff opened this issue Sep 22, 2024 · 0 comments
Labels
waiting for next tag PR which are now completed and are waiting for a next tag

Comments

@scarlehoff
Copy link
Member

At the moment we are using the legacy names for some seeding

nnpdf/validphys2/src/validphys/pseudodata.py

Line 200 in 8b588b8

for loaded_cd in groups_dataset_inputs_loaded_cd_with_cuts:
in order to reproduce legacy results.

Since the names have now changed, this will be removed at some point before the next tag (as close as possible to the next tag so that most of 4.0.9 remains unchanged)
@scarlehoff scarlehoff added the waiting for next tag PR which are now completed and are waiting for a next tag label Sep 22, 2024
@scarlehoff scarlehoff mentioned this issue Nov 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
waiting for next tag PR which are now completed and are waiting for a next tag
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@scarlehoff