diff --git a/.gitmodules b/.gitmodules index 22c723ac1..b52114e01 100644 --- a/.gitmodules +++ b/.gitmodules @@ -8,8 +8,8 @@ branch = main [submodule "ccpp/physics"] path = ccpp/physics - url = https://github.com/ufs-community/ccpp-physics - branch = ufs/dev + url = https://github.com/LarissaReames-NOAA/ccpp-physics + branch = feature/rad-fix [submodule "upp"] path = upp url = https://github.com/NOAA-EMC/UPP diff --git a/atmos_model.F90 b/atmos_model.F90 index 5525b5b58..8b4003028 100644 --- a/atmos_model.F90 +++ b/atmos_model.F90 @@ -975,6 +975,7 @@ subroutine update_atmos_model_state (Atmos, rc) !--- local variables integer :: i, localrc, sec_lastfhzerofh integer :: isec, seconds, isec_fhzero + integer :: dtatm_temp logical :: tmpflag_fhzero real(kind=GFS_kind_phys) :: time_int, time_intfull ! @@ -1021,9 +1022,10 @@ subroutine update_atmos_model_state (Atmos, rc) endif if (mpp_pe() == mpp_root_pe()) write(6,*) ' gfs diags time since last bucket empty: ',time_int/3600.,'hrs' call atmosphere_nggps_diag(Atmos%Time) + call get_time ( Atmos%Time_step, dtatm_temp) call fv3atm_diag_output(Atmos%Time, GFS_Diag, Atm_block, GFS_control%nx, GFS_control%ny, & GFS_control%levs, 1, 1, 1.0_GFS_kind_phys, time_int, time_intfull, & - GFS_control%fhswr, GFS_control%fhlwr) + GFS_control%fhswr, GFS_control%fhlwr, dtatm_temp) endif !--- find current fhzero diff --git a/ccpp/config/ccpp_prebuild_config.py b/ccpp/config/ccpp_prebuild_config.py index 5e91f3ef6..892e96d61 100755 --- a/ccpp/config/ccpp_prebuild_config.py +++ b/ccpp/config/ccpp_prebuild_config.py @@ -99,7 +99,7 @@ 'physics/physics/Interstitials/UFS_SCM_NEPTUNE/GFS_photochemistry.F90', 'physics/physics/Interstitials/UFS_SCM_NEPTUNE/GFS_rad_time_vary.fv3.F90', 'physics/physics/Interstitials/UFS_SCM_NEPTUNE/GFS_radiation_surface.F90', - 'physics/physics/Interstitials/UFS_SCM_NEPTUNE/GFS_rrtmg_post.F90', + 'physics/physics/Interstitials/UFS_SCM_NEPTUNE/GFS_radiation_post.F90', 'physics/physics/Interstitials/UFS_SCM_NEPTUNE/GFS_rrtmg_pre.F90', 'physics/physics/Interstitials/UFS_SCM_NEPTUNE/GFS_rrtmg_setup.F90', 'physics/physics/Interstitials/UFS_SCM_NEPTUNE/GFS_rrtmgp_setup.F90', @@ -107,7 +107,6 @@ 'physics/physics/Interstitials/UFS_SCM_NEPTUNE/GFS_cloud_diagnostics.F90', 'physics/physics/Interstitials/UFS_SCM_NEPTUNE/GFS_rrtmgp_cloud_mp.F90', 'physics/physics/Interstitials/UFS_SCM_NEPTUNE/GFS_rrtmgp_cloud_overlap.F90', - 'physics/physics/Interstitials/UFS_SCM_NEPTUNE/GFS_rrtmgp_post.F90', 'physics/physics/Interstitials/UFS_SCM_NEPTUNE/GFS_stochastics.F90', 'physics/physics/Interstitials/UFS_SCM_NEPTUNE/GFS_suite_interstitial_rad_reset.F90', 'physics/physics/Interstitials/UFS_SCM_NEPTUNE/GFS_suite_interstitial_phys_reset.F90', diff --git a/ccpp/physics b/ccpp/physics index dab57fcce..9d251bae8 160000 --- a/ccpp/physics +++ b/ccpp/physics @@ -1 +1 @@ -Subproject commit dab57fcce3f1abf16eb01f22469ea84279f67b19 +Subproject commit 9d251bae8023b47d01ede411c96ae5ee471a2db5 diff --git a/ccpp/suites/suite_FV3_GFS_v15_thompson_mynn_lam3km.xml b/ccpp/suites/suite_FV3_GFS_v15_thompson_mynn_lam3km.xml index 3b93422b5..c3ff1ac7b 100644 --- a/ccpp/suites/suite_FV3_GFS_v15_thompson_mynn_lam3km.xml +++ b/ccpp/suites/suite_FV3_GFS_v15_thompson_mynn_lam3km.xml @@ -22,7 +22,7 @@ rrtmg_lw sgscloud_radpost rrtmg_lw_post - GFS_rrtmg_post + GFS_radiation_post diff --git a/ccpp/suites/suite_FV3_GFS_v15p2.xml b/ccpp/suites/suite_FV3_GFS_v15p2.xml index bd7225019..23f46e2cb 100644 --- a/ccpp/suites/suite_FV3_GFS_v15p2.xml +++ b/ccpp/suites/suite_FV3_GFS_v15p2.xml @@ -25,7 +25,7 @@ rrtmg_sw_post rrtmg_lw rrtmg_lw_post - GFS_rrtmg_post + GFS_radiation_post diff --git a/ccpp/suites/suite_FV3_GFS_v16.xml b/ccpp/suites/suite_FV3_GFS_v16.xml index 37de8fbc5..edab22b3a 100644 --- a/ccpp/suites/suite_FV3_GFS_v16.xml +++ b/ccpp/suites/suite_FV3_GFS_v16.xml @@ -25,7 +25,7 @@ rrtmg_sw_post rrtmg_lw rrtmg_lw_post - GFS_rrtmg_post + GFS_radiation_post diff --git a/ccpp/suites/suite_FV3_GFS_v16_csawmg.xml b/ccpp/suites/suite_FV3_GFS_v16_csawmg.xml index 907a0234c..67ecf7d8b 100644 --- a/ccpp/suites/suite_FV3_GFS_v16_csawmg.xml +++ b/ccpp/suites/suite_FV3_GFS_v16_csawmg.xml @@ -20,7 +20,7 @@ rrtmg_sw_post rrtmg_lw rrtmg_lw_post - GFS_rrtmg_post + GFS_radiation_post diff --git a/ccpp/suites/suite_FV3_GFS_v16_flake.xml b/ccpp/suites/suite_FV3_GFS_v16_flake.xml index c11b2afdf..ae893dc8e 100644 --- a/ccpp/suites/suite_FV3_GFS_v16_flake.xml +++ b/ccpp/suites/suite_FV3_GFS_v16_flake.xml @@ -25,7 +25,7 @@ rrtmg_sw_post rrtmg_lw rrtmg_lw_post - GFS_rrtmg_post + GFS_radiation_post diff --git a/ccpp/suites/suite_FV3_GFS_v16_fv3wam.xml b/ccpp/suites/suite_FV3_GFS_v16_fv3wam.xml index e10022121..46950cd48 100644 --- a/ccpp/suites/suite_FV3_GFS_v16_fv3wam.xml +++ b/ccpp/suites/suite_FV3_GFS_v16_fv3wam.xml @@ -20,7 +20,7 @@ rrtmg_sw_post rrtmg_lw rrtmg_lw_post - GFS_rrtmg_post + GFS_radiation_post diff --git a/ccpp/suites/suite_FV3_GFS_v16_ras.xml b/ccpp/suites/suite_FV3_GFS_v16_ras.xml index 0545de59a..cbc1c3095 100644 --- a/ccpp/suites/suite_FV3_GFS_v16_ras.xml +++ b/ccpp/suites/suite_FV3_GFS_v16_ras.xml @@ -25,7 +25,7 @@ rrtmg_sw_post rrtmg_lw rrtmg_lw_post - GFS_rrtmg_post + GFS_radiation_post diff --git a/ccpp/suites/suite_FV3_GFS_v17_coupled_p8.xml b/ccpp/suites/suite_FV3_GFS_v17_coupled_p8.xml index 0cf5f40af..9fcec858b 100644 --- a/ccpp/suites/suite_FV3_GFS_v17_coupled_p8.xml +++ b/ccpp/suites/suite_FV3_GFS_v17_coupled_p8.xml @@ -20,7 +20,7 @@ rrtmg_sw_post rrtmg_lw rrtmg_lw_post - GFS_rrtmg_post + GFS_radiation_post diff --git a/ccpp/suites/suite_FV3_GFS_v17_coupled_p8_c3.xml b/ccpp/suites/suite_FV3_GFS_v17_coupled_p8_c3.xml index bba0f5b78..e3c44dfcb 100644 --- a/ccpp/suites/suite_FV3_GFS_v17_coupled_p8_c3.xml +++ b/ccpp/suites/suite_FV3_GFS_v17_coupled_p8_c3.xml @@ -20,7 +20,7 @@ rrtmg_sw_post rrtmg_lw rrtmg_lw_post - GFS_rrtmg_post + GFS_radiation_post diff --git a/ccpp/suites/suite_FV3_GFS_v17_coupled_p8_sfcocn.xml b/ccpp/suites/suite_FV3_GFS_v17_coupled_p8_sfcocn.xml index 3d25ec17b..377904df5 100644 --- a/ccpp/suites/suite_FV3_GFS_v17_coupled_p8_sfcocn.xml +++ b/ccpp/suites/suite_FV3_GFS_v17_coupled_p8_sfcocn.xml @@ -20,7 +20,7 @@ rrtmg_sw_post rrtmg_lw rrtmg_lw_post - GFS_rrtmg_post + GFS_radiation_post diff --git a/ccpp/suites/suite_FV3_GFS_v17_coupled_p8_ugwpv1.xml b/ccpp/suites/suite_FV3_GFS_v17_coupled_p8_ugwpv1.xml index e7bb03710..776c0a2e5 100644 --- a/ccpp/suites/suite_FV3_GFS_v17_coupled_p8_ugwpv1.xml +++ b/ccpp/suites/suite_FV3_GFS_v17_coupled_p8_ugwpv1.xml @@ -20,7 +20,7 @@ rrtmg_sw_post rrtmg_lw rrtmg_lw_post - GFS_rrtmg_post + GFS_radiation_post diff --git a/ccpp/suites/suite_FV3_GFS_v17_p8.xml b/ccpp/suites/suite_FV3_GFS_v17_p8.xml index 58f9431a8..bf6ed924a 100644 --- a/ccpp/suites/suite_FV3_GFS_v17_p8.xml +++ b/ccpp/suites/suite_FV3_GFS_v17_p8.xml @@ -20,7 +20,7 @@ rrtmg_sw_post rrtmg_lw rrtmg_lw_post - GFS_rrtmg_post + GFS_radiation_post diff --git a/ccpp/suites/suite_FV3_GFS_v17_p8_c3.xml b/ccpp/suites/suite_FV3_GFS_v17_p8_c3.xml index 54258c15e..e1ac47f13 100644 --- a/ccpp/suites/suite_FV3_GFS_v17_p8_c3.xml +++ b/ccpp/suites/suite_FV3_GFS_v17_p8_c3.xml @@ -22,7 +22,7 @@ rrtmg_lw sgscloud_radpost rrtmg_lw_post - GFS_rrtmg_post + GFS_radiation_post diff --git a/ccpp/suites/suite_FV3_GFS_v17_p8_mynn.xml b/ccpp/suites/suite_FV3_GFS_v17_p8_mynn.xml index e54c3ab06..b35bfb588 100644 --- a/ccpp/suites/suite_FV3_GFS_v17_p8_mynn.xml +++ b/ccpp/suites/suite_FV3_GFS_v17_p8_mynn.xml @@ -22,7 +22,7 @@ rrtmg_lw sgscloud_radpost rrtmg_lw_post - GFS_rrtmg_post + GFS_radiation_post diff --git a/ccpp/suites/suite_FV3_GFS_v17_p8_rrtmgp.xml b/ccpp/suites/suite_FV3_GFS_v17_p8_rrtmgp.xml index 1bbd34def..b00f738d9 100644 --- a/ccpp/suites/suite_FV3_GFS_v17_p8_rrtmgp.xml +++ b/ccpp/suites/suite_FV3_GFS_v17_p8_rrtmgp.xml @@ -21,7 +21,7 @@ rrtmgp_aerosol_optics rrtmgp_sw_main rrtmgp_lw_main - GFS_rrtmgp_post + GFS_radiation_post diff --git a/ccpp/suites/suite_FV3_GFS_v17_p8_ugwpv1.xml b/ccpp/suites/suite_FV3_GFS_v17_p8_ugwpv1.xml index c94396454..8111017f8 100644 --- a/ccpp/suites/suite_FV3_GFS_v17_p8_ugwpv1.xml +++ b/ccpp/suites/suite_FV3_GFS_v17_p8_ugwpv1.xml @@ -20,7 +20,7 @@ rrtmg_sw_post rrtmg_lw rrtmg_lw_post - GFS_rrtmg_post + GFS_radiation_post diff --git a/ccpp/suites/suite_FV3_HAFS_v1_gfdlmp_tedmf.xml b/ccpp/suites/suite_FV3_HAFS_v1_gfdlmp_tedmf.xml index db918c643..b40ba09eb 100644 --- a/ccpp/suites/suite_FV3_HAFS_v1_gfdlmp_tedmf.xml +++ b/ccpp/suites/suite_FV3_HAFS_v1_gfdlmp_tedmf.xml @@ -25,7 +25,7 @@ rrtmg_sw_post rrtmg_lw rrtmg_lw_post - GFS_rrtmg_post + GFS_radiation_post diff --git a/ccpp/suites/suite_FV3_HAFS_v1_gfdlmp_tedmf_nonsst.xml b/ccpp/suites/suite_FV3_HAFS_v1_gfdlmp_tedmf_nonsst.xml index f2a02001e..97180c073 100644 --- a/ccpp/suites/suite_FV3_HAFS_v1_gfdlmp_tedmf_nonsst.xml +++ b/ccpp/suites/suite_FV3_HAFS_v1_gfdlmp_tedmf_nonsst.xml @@ -25,7 +25,7 @@ rrtmg_sw_post rrtmg_lw rrtmg_lw_post - GFS_rrtmg_post + GFS_radiation_post diff --git a/ccpp/suites/suite_FV3_HAFS_v1_thompson.xml b/ccpp/suites/suite_FV3_HAFS_v1_thompson.xml index 6a043e897..fffc713cf 100644 --- a/ccpp/suites/suite_FV3_HAFS_v1_thompson.xml +++ b/ccpp/suites/suite_FV3_HAFS_v1_thompson.xml @@ -20,7 +20,7 @@ rrtmg_sw_post rrtmg_lw rrtmg_lw_post - GFS_rrtmg_post + GFS_radiation_post diff --git a/ccpp/suites/suite_FV3_HAFS_v1_thompson_nonsst.xml b/ccpp/suites/suite_FV3_HAFS_v1_thompson_nonsst.xml index 5408b3898..8cd493754 100644 --- a/ccpp/suites/suite_FV3_HAFS_v1_thompson_nonsst.xml +++ b/ccpp/suites/suite_FV3_HAFS_v1_thompson_nonsst.xml @@ -20,7 +20,7 @@ rrtmg_sw_post rrtmg_lw rrtmg_lw_post - GFS_rrtmg_post + GFS_radiation_post diff --git a/ccpp/suites/suite_FV3_HAFS_v1_thompson_tedmf_gfdlsf.xml b/ccpp/suites/suite_FV3_HAFS_v1_thompson_tedmf_gfdlsf.xml index 6283e3a3f..0f482634f 100644 --- a/ccpp/suites/suite_FV3_HAFS_v1_thompson_tedmf_gfdlsf.xml +++ b/ccpp/suites/suite_FV3_HAFS_v1_thompson_tedmf_gfdlsf.xml @@ -20,7 +20,7 @@ rrtmg_sw_post rrtmg_lw rrtmg_lw_post - GFS_rrtmg_post + GFS_radiation_post diff --git a/ccpp/suites/suite_FV3_HRRR.xml b/ccpp/suites/suite_FV3_HRRR.xml index fabe94665..3d1e34175 100644 --- a/ccpp/suites/suite_FV3_HRRR.xml +++ b/ccpp/suites/suite_FV3_HRRR.xml @@ -22,7 +22,7 @@ rrtmg_lw sgscloud_radpost rrtmg_lw_post - GFS_rrtmg_post + GFS_radiation_post diff --git a/ccpp/suites/suite_FV3_HRRR_c3.xml b/ccpp/suites/suite_FV3_HRRR_c3.xml index c0f3ec1f5..0e3ff1da3 100644 --- a/ccpp/suites/suite_FV3_HRRR_c3.xml +++ b/ccpp/suites/suite_FV3_HRRR_c3.xml @@ -22,7 +22,7 @@ rrtmg_lw sgscloud_radpost rrtmg_lw_post - GFS_rrtmg_post + GFS_radiation_post diff --git a/ccpp/suites/suite_FV3_HRRR_gf.xml b/ccpp/suites/suite_FV3_HRRR_gf.xml index f3f227106..4222beac0 100644 --- a/ccpp/suites/suite_FV3_HRRR_gf.xml +++ b/ccpp/suites/suite_FV3_HRRR_gf.xml @@ -22,7 +22,7 @@ rrtmg_lw sgscloud_radpost rrtmg_lw_post - GFS_rrtmg_post + GFS_radiation_post diff --git a/ccpp/suites/suite_FV3_HRRR_gf_nogwd.xml b/ccpp/suites/suite_FV3_HRRR_gf_nogwd.xml index 6b01cbd79..233fd2070 100644 --- a/ccpp/suites/suite_FV3_HRRR_gf_nogwd.xml +++ b/ccpp/suites/suite_FV3_HRRR_gf_nogwd.xml @@ -22,7 +22,7 @@ rrtmg_lw sgscloud_radpost rrtmg_lw_post - GFS_rrtmg_post + GFS_radiation_post diff --git a/ccpp/suites/suite_FV3_RAP.xml b/ccpp/suites/suite_FV3_RAP.xml index c2243e3fa..65fa424ba 100644 --- a/ccpp/suites/suite_FV3_RAP.xml +++ b/ccpp/suites/suite_FV3_RAP.xml @@ -22,7 +22,7 @@ rrtmg_lw sgscloud_radpost rrtmg_lw_post - GFS_rrtmg_post + GFS_radiation_post diff --git a/ccpp/suites/suite_FV3_RAP_cires_ugwp.xml b/ccpp/suites/suite_FV3_RAP_cires_ugwp.xml index 7760b059c..7c0b7e461 100644 --- a/ccpp/suites/suite_FV3_RAP_cires_ugwp.xml +++ b/ccpp/suites/suite_FV3_RAP_cires_ugwp.xml @@ -22,7 +22,7 @@ rrtmg_lw sgscloud_radpost rrtmg_lw_post - GFS_rrtmg_post + GFS_radiation_post diff --git a/ccpp/suites/suite_FV3_RAP_clm_lake.xml b/ccpp/suites/suite_FV3_RAP_clm_lake.xml index d794cd74a..acde3cbc6 100644 --- a/ccpp/suites/suite_FV3_RAP_clm_lake.xml +++ b/ccpp/suites/suite_FV3_RAP_clm_lake.xml @@ -22,7 +22,7 @@ rrtmg_lw sgscloud_radpost rrtmg_lw_post - GFS_rrtmg_post + GFS_radiation_post diff --git a/ccpp/suites/suite_FV3_RAP_flake.xml b/ccpp/suites/suite_FV3_RAP_flake.xml index 652071989..3f809c899 100644 --- a/ccpp/suites/suite_FV3_RAP_flake.xml +++ b/ccpp/suites/suite_FV3_RAP_flake.xml @@ -22,7 +22,7 @@ rrtmg_lw sgscloud_radpost rrtmg_lw_post - GFS_rrtmg_post + GFS_radiation_post diff --git a/ccpp/suites/suite_FV3_RAP_noah.xml b/ccpp/suites/suite_FV3_RAP_noah.xml index 7311eb989..a79a9f01c 100644 --- a/ccpp/suites/suite_FV3_RAP_noah.xml +++ b/ccpp/suites/suite_FV3_RAP_noah.xml @@ -22,7 +22,7 @@ rrtmg_lw sgscloud_radpost rrtmg_lw_post - GFS_rrtmg_post + GFS_radiation_post diff --git a/ccpp/suites/suite_FV3_RAP_noah_sfcdiff_cires_ugwp.xml b/ccpp/suites/suite_FV3_RAP_noah_sfcdiff_cires_ugwp.xml index 229ebc08f..da9c615f8 100644 --- a/ccpp/suites/suite_FV3_RAP_noah_sfcdiff_cires_ugwp.xml +++ b/ccpp/suites/suite_FV3_RAP_noah_sfcdiff_cires_ugwp.xml @@ -22,7 +22,7 @@ rrtmg_lw sgscloud_radpost rrtmg_lw_post - GFS_rrtmg_post + GFS_radiation_post diff --git a/ccpp/suites/suite_FV3_RAP_sfcdiff.xml b/ccpp/suites/suite_FV3_RAP_sfcdiff.xml index 7c2908a25..a9ca70040 100644 --- a/ccpp/suites/suite_FV3_RAP_sfcdiff.xml +++ b/ccpp/suites/suite_FV3_RAP_sfcdiff.xml @@ -22,7 +22,7 @@ rrtmg_lw sgscloud_radpost rrtmg_lw_post - GFS_rrtmg_post + GFS_radiation_post diff --git a/ccpp/suites/suite_FV3_RAP_unified_ugwp.xml b/ccpp/suites/suite_FV3_RAP_unified_ugwp.xml index 6913b8e4a..579deed74 100644 --- a/ccpp/suites/suite_FV3_RAP_unified_ugwp.xml +++ b/ccpp/suites/suite_FV3_RAP_unified_ugwp.xml @@ -22,7 +22,7 @@ rrtmg_lw sgscloud_radpost rrtmg_lw_post - GFS_rrtmg_post + GFS_radiation_post diff --git a/ccpp/suites/suite_FV3_RRFS_v1beta.xml b/ccpp/suites/suite_FV3_RRFS_v1beta.xml index 01589e271..876a98679 100644 --- a/ccpp/suites/suite_FV3_RRFS_v1beta.xml +++ b/ccpp/suites/suite_FV3_RRFS_v1beta.xml @@ -22,7 +22,7 @@ rrtmg_lw sgscloud_radpost rrtmg_lw_post - GFS_rrtmg_post + GFS_radiation_post diff --git a/ccpp/suites/suite_FV3_RRFS_v1nssl.xml b/ccpp/suites/suite_FV3_RRFS_v1nssl.xml index 107254b18..9b244c9e4 100644 --- a/ccpp/suites/suite_FV3_RRFS_v1nssl.xml +++ b/ccpp/suites/suite_FV3_RRFS_v1nssl.xml @@ -22,7 +22,7 @@ rrtmg_lw sgscloud_radpost rrtmg_lw_post - GFS_rrtmg_post + GFS_radiation_post diff --git a/ccpp/suites/suite_FV3_WoFS_v0.xml b/ccpp/suites/suite_FV3_WoFS_v0.xml index 6e68a9773..0a344de79 100644 --- a/ccpp/suites/suite_FV3_WoFS_v0.xml +++ b/ccpp/suites/suite_FV3_WoFS_v0.xml @@ -22,7 +22,7 @@ rrtmg_lw sgscloud_radpost rrtmg_lw_post - GFS_rrtmg_post + GFS_radiation_post diff --git a/ccpp/suites/suite_FV3_global_nest_v1.xml b/ccpp/suites/suite_FV3_global_nest_v1.xml index 79ef5545f..48f56bc36 100644 --- a/ccpp/suites/suite_FV3_global_nest_v1.xml +++ b/ccpp/suites/suite_FV3_global_nest_v1.xml @@ -22,7 +22,7 @@ rrtmg_lw sgscloud_radpost rrtmg_lw_post - GFS_rrtmg_post + GFS_radiation_post diff --git a/ccpp/suites/suite_RRFSens_phy1.xml b/ccpp/suites/suite_RRFSens_phy1.xml index e5c6f7a91..538618da4 100644 --- a/ccpp/suites/suite_RRFSens_phy1.xml +++ b/ccpp/suites/suite_RRFSens_phy1.xml @@ -22,7 +22,7 @@ rrtmg_lw sgscloud_radpost rrtmg_lw_post - GFS_rrtmg_post + GFS_radiation_post diff --git a/ccpp/suites/suite_RRFSens_phy2.xml b/ccpp/suites/suite_RRFSens_phy2.xml index e2f730833..59bdbd3bc 100644 --- a/ccpp/suites/suite_RRFSens_phy2.xml +++ b/ccpp/suites/suite_RRFSens_phy2.xml @@ -22,7 +22,7 @@ rrtmg_lw sgscloud_radpost rrtmg_lw_post - GFS_rrtmg_post + GFS_radiation_post diff --git a/ccpp/suites/suite_RRFSens_phy3.xml b/ccpp/suites/suite_RRFSens_phy3.xml index 470f5d15d..bb782b163 100644 --- a/ccpp/suites/suite_RRFSens_phy3.xml +++ b/ccpp/suites/suite_RRFSens_phy3.xml @@ -22,7 +22,7 @@ rrtmg_lw sgscloud_radpost rrtmg_lw_post - GFS_rrtmg_post + GFS_radiation_post diff --git a/ccpp/suites/suite_RRFSens_phy4.xml b/ccpp/suites/suite_RRFSens_phy4.xml index 5813576c8..0d3504d1e 100644 --- a/ccpp/suites/suite_RRFSens_phy4.xml +++ b/ccpp/suites/suite_RRFSens_phy4.xml @@ -22,7 +22,7 @@ rrtmg_lw sgscloud_radpost rrtmg_lw_post - GFS_rrtmg_post + GFS_radiation_post diff --git a/ccpp/suites/suite_RRFSens_phy5.xml b/ccpp/suites/suite_RRFSens_phy5.xml index c06338056..4ed85d767 100644 --- a/ccpp/suites/suite_RRFSens_phy5.xml +++ b/ccpp/suites/suite_RRFSens_phy5.xml @@ -22,7 +22,7 @@ rrtmg_lw sgscloud_radpost rrtmg_lw_post - GFS_rrtmg_post + GFS_radiation_post diff --git a/io/fv3atm_history_io.F90 b/io/fv3atm_history_io.F90 index 6fe537e04..1e3de8c06 100644 --- a/io/fv3atm_history_io.F90 +++ b/io/fv3atm_history_io.F90 @@ -115,12 +115,12 @@ end subroutine fv3atm_diag_register !! This routine transfers diagnostic data to the FMS diagnostic !! manager for eventual output to the history files. subroutine fv3atm_diag_output(time, diag, atm_block, nx, ny, levs, ntcw, ntoz, & - dt, time_int, time_intfull, time_radsw, time_radlw) + dt, time_int, time_intfull, time_radsw, time_radlw, dt_atmos) !--- subroutine interface variable definitions type(time_type), intent(in) :: time type(GFS_externaldiag_type), intent(in) :: diag(:) type (block_control_type), intent(in) :: atm_block - integer, intent(in) :: nx, ny, levs, ntcw, ntoz + integer, intent(in) :: nx, ny, levs, ntcw, ntoz, dt_atmos real(kind=kind_phys), intent(in) :: dt real(kind=kind_phys), intent(in) :: time_int real(kind=kind_phys), intent(in) :: time_intfull @@ -128,7 +128,7 @@ subroutine fv3atm_diag_output(time, diag, atm_block, nx, ny, levs, ntcw, ntoz, & real(kind=kind_phys), intent(in) :: time_radlw call shared_history_data%output(time, diag, atm_block, nx, ny, levs, ntcw, ntoz, & - dt, time_int, time_intfull, time_radsw, time_radlw) + dt, time_int, time_intfull, time_radsw, time_radlw, dt_atmos) end subroutine fv3atm_diag_output @@ -282,13 +282,13 @@ end subroutine history_type_register !! implementation of the public fv3atm_diag_output routine. Never !! call this directly. subroutine history_type_output(hist, time, diag, atm_block, nx, ny, levs, ntcw, ntoz, & - dt, time_int, time_intfull, time_radsw, time_radlw) + dt, time_int, time_intfull, time_radsw, time_radlw, dt_atmos) !--- subroutine interface variable definitions class(history_type) :: hist type(time_type), intent(in) :: time type(GFS_externaldiag_type), intent(in) :: diag(:) type (block_control_type), intent(in) :: atm_block - integer, intent(in) :: nx, ny, levs, ntcw, ntoz + integer, intent(in) :: nx, ny, levs, ntcw, ntoz, dt_atmos real(kind=kind_phys), intent(in) :: dt real(kind=kind_phys), intent(in) :: time_int real(kind=kind_phys), intent(in) :: time_intfull @@ -321,13 +321,16 @@ subroutine history_type_output(hist, time, diag, atm_block, nx, ny, levs, ntcw, lcnvfac = lcnvfac*rtime_intfull ! if(mpp_pe()==mpp_root_pe())print *,'in,fv3atm_io. full time avg, field=',trim(Diag(idx)%name),' time=',time_intfull else if ( trim(diag(idx)%time_avg_kind) == 'rad_lw' ) then - lcnvfac = lcnvfac*min(rtime_radlw,rtime_int) + !lcnvfac = lcnvfac*min(rtime_radlw,rtime_int) + lcnvfac = lcnvfac*rtime_radlw/int(time_int/dt_atmos) ! if(mpp_pe()==mpp_root_pe())print *,'in,fv3atm_io. rad longwave avg, field=',trim(Diag(idx)%name),' time=',time_radlw else if ( trim(diag(idx)%time_avg_kind) == 'rad_sw' ) then - lcnvfac = lcnvfac*min(rtime_radsw,rtime_int) + !lcnvfac = lcnvfac*min(rtime_radsw,rtime_int) + lcnvfac = lcnvfac*rtime_radsw/int(time_int/dt_atmos) ! if(mpp_pe()==mpp_root_pe())print *,'in,fv3atm_io. rad shortwave avg, field=',trim(Diag(idx)%name),' time=',time_radsw else if ( trim(diag(idx)%time_avg_kind) == 'rad_swlw_min' ) then - lcnvfac = lcnvfac*min(max(rtime_radsw,rtime_radlw),rtime_int) + !lcnvfac = lcnvfac*min(max(rtime_radsw,rtime_radlw),rtime_int) + lcnvfac = lcnvfac*max(rtime_radsw,rtime_radlw)/int(time_int/dt_atmos) ! if(mpp_pe()==mpp_root_pe())print *,'in,fv3atm_io. rad swlw min avg, field=',trim(Diag(idx)%name),' time=',time_radlw,time_radsw,time_int else lcnvfac = lcnvfac*rtime_int