Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fregrid_acc: change constants to "const data_type var_name = value" #283

Open
mlee03 opened this issue Mar 29, 2024 · 0 comments
Open

fregrid_acc: change constants to "const data_type var_name = value" #283

mlee03 opened this issue Mar 29, 2024 · 0 comments

Comments

@mlee03
Copy link
Contributor

mlee03 commented Mar 29, 2024

Is your feature request related to a problem? Please describe.
In current libfrencutils, constants in constants.h are defined as macros and are handled by the preprocessor. However this is not the preferred method for fregrid_acc implementation as it could lead to bugs, maintainability issues, and loss of precision.

Describe the solution you'd like
Constant values in libfrencutils/constants.h will be defined as const data_type var_name = value in a new file called libfrencutils_acc/constants_acc.h. All fregrid_acc related code will #include constants_acc.h

Describe alternatives you've considered
Leave as is

Additional context
N/A

@mlee03 mlee03 changed the title fregrid_acc: change constant to "const data_type var_name = value" fregrid_acc: change constants to "const data_type var_name = value" Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant