You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
In current libfrencutils, constants in constants.h are defined as macros and are handled by the preprocessor. However this is not the preferred method for fregrid_acc implementation as it could lead to bugs, maintainability issues, and loss of precision.
Describe the solution you'd like
Constant values in libfrencutils/constants.h will be defined as const data_type var_name = value in a new file called libfrencutils_acc/constants_acc.h. All fregrid_acc related code will #include constants_acc.h
Describe alternatives you've considered
Leave as is
Additional context
N/A
The text was updated successfully, but these errors were encountered:
mlee03
changed the title
fregrid_acc: change constant to "const data_type var_name = value"
fregrid_acc: change constants to "const data_type var_name = value"
Mar 29, 2024
Is your feature request related to a problem? Please describe.
In current libfrencutils, constants in
constants.h
are defined as macros and are handled by the preprocessor. However this is not the preferred method forfregrid_acc
implementation as it could lead to bugs, maintainability issues, and loss of precision.Describe the solution you'd like
Constant values in libfrencutils/constants.h will be defined as
const data_type var_name = value
in a new file calledlibfrencutils_acc/constants_acc.h
. Allfregrid_acc
related code will #include constants_acc.hDescribe alternatives you've considered
Leave as is
Additional context
N/A
The text was updated successfully, but these errors were encountered: