Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand formalized testing of build scenarios with user-provided include paths #887

Open
robertbartel opened this issue Oct 4, 2024 · 0 comments
Labels
build Issues related to CMake and building ngen QA/QC

Comments

@robertbartel
Copy link
Contributor

Make sure there is sufficient testing of build functionality for scenarios involving a user-provided include path for dependencies, such as UDUNITS2. Tests of varying degrees of specificity can potentially happen at multiple event levels; e.g., some tests are performed automatically with every PR, some tests are run nightly, some tests are run during the release process; etc.

This relates to #725. Today, an example was reported with UDUNITS2_ROOT set when generating the build directory with CMake, where (despite CMake seemingly finding the right include path) the build failed due to:

..../ngen/include/core/mediator/UnitsHelper.hpp:14:14: fatal error: udunits2.h: No such file or directory

As noted near the bottom of #725, there is probably a workaround for this (though that isn't well document, yet: see #886). But the progression of that PR demonstrated that it's easy to miss when a subtle difference (either in the build setup or the environment) could break build behavior. We would benefit from making sure this is well tested.

We should also make sure to account for similar situations with any other user-provided paths; e.g. NETCDF_ROOT.

@robertbartel robertbartel added build Issues related to CMake and building ngen QA/QC labels Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues related to CMake and building ngen QA/QC
Projects
None yet
Development

No branches or pull requests

1 participant