From 8c4c4bc0c603bc4c0a2b900064cea45b3d07b9d3 Mon Sep 17 00:00:00 2001
From: Cesar199999 <cesar.descalzo2@gmail.com>
Date: Tue, 25 Jun 2024 16:12:24 +0200
Subject: [PATCH 1/5] Impl sub, mul and div for actual objects

---
 poly/src/polynomial/univariate/dense.rs | 27 +++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/poly/src/polynomial/univariate/dense.rs b/poly/src/polynomial/univariate/dense.rs
index 1df019d58..f9cec676f 100644
--- a/poly/src/polynomial/univariate/dense.rs
+++ b/poly/src/polynomial/univariate/dense.rs
@@ -487,6 +487,15 @@ impl<'a, 'b, F: Field> Sub<&'a DensePolynomial<F>> for &'b DensePolynomial<F> {
     }
 }
 
+impl<F: Field> Sub<DensePolynomial<F>> for DensePolynomial<F> {
+    type Output = DensePolynomial<F>;
+
+    #[inline]
+    fn sub(self, other: DensePolynomial<F>) -> DensePolynomial<F> {
+        &self - &other
+    }
+}
+
 impl<'a, 'b, F: Field> Sub<&'a SparsePolynomial<F>> for &'b DensePolynomial<F> {
     type Output = DensePolynomial<F>;
 
@@ -584,6 +593,15 @@ impl<'a, 'b, F: Field> Div<&'a DensePolynomial<F>> for &'b DensePolynomial<F> {
     }
 }
 
+impl<F: Field> Div<DensePolynomial<F>> for DensePolynomial<F> {
+    type Output = DensePolynomial<F>;
+
+    #[inline]
+    fn div(self, divisor: DensePolynomial<F>) -> DensePolynomial<F> {
+        &self / &divisor
+    }
+}
+
 impl<'b, F: Field> Mul<F> for &'b DensePolynomial<F> {
     type Output = DensePolynomial<F>;
 
@@ -620,6 +638,15 @@ impl<'a, 'b, F: FftField> Mul<&'a DensePolynomial<F>> for &'b DensePolynomial<F>
     }
 }
 
+impl<F: FftField> Mul<DensePolynomial<F>> for DensePolynomial<F> {
+    type Output = DensePolynomial<F>;
+
+    #[inline]
+    fn mul(self, other: DensePolynomial<F>) -> DensePolynomial<F> {
+        &self * &other
+    }
+}
+
 impl<F: Field> Zero for DensePolynomial<F> {
     /// Returns the zero polynomial.
     fn zero() -> Self {

From 399264ef54dea8893365dd7738ebd96d251756c5 Mon Sep 17 00:00:00 2001
From: Cesar199999 <cesar.descalzo2@gmail.com>
Date: Wed, 26 Jun 2024 09:33:01 +0200
Subject: [PATCH 2/5] Add non-reference scalar multiplication
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Co-authored-by: Antonio Mejías Gil <anmegi.95@gmail.com>
---
 poly/src/polynomial/univariate/dense.rs | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/poly/src/polynomial/univariate/dense.rs b/poly/src/polynomial/univariate/dense.rs
index f9cec676f..3dfd3dfeb 100644
--- a/poly/src/polynomial/univariate/dense.rs
+++ b/poly/src/polynomial/univariate/dense.rs
@@ -619,6 +619,15 @@ impl<'b, F: Field> Mul<F> for &'b DensePolynomial<F> {
     }
 }
 
+impl<F: Field> Mul<F> for DensePolynomial<F> {
+    type Output = DensePolynomial<F>;
+
+    #[inline]
+    fn mul(self, elem: F) -> DensePolynomial<F> {
+        &self * elem
+    }
+}
+
 /// Performs O(nlogn) multiplication of polynomials if F is smooth.
 impl<'a, 'b, F: FftField> Mul<&'a DensePolynomial<F>> for &'b DensePolynomial<F> {
     type Output = DensePolynomial<F>;

From 865505507f9727d29250d5e1798b3890b8635832 Mon Sep 17 00:00:00 2001
From: Cesar199999 <cesar.descalzo2@gmail.com>
Date: Wed, 26 Jun 2024 11:07:28 +0200
Subject: [PATCH 3/5] Implement arithmetic operators with a macro
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Co-authored-by: Antonio Mejías Gil <anmegi.95@gmail.com>
---
 poly/src/polynomial/univariate/dense.rs | 65 +++++++++++++------------
 1 file changed, 33 insertions(+), 32 deletions(-)

diff --git a/poly/src/polynomial/univariate/dense.rs b/poly/src/polynomial/univariate/dense.rs
index 3dfd3dfeb..dca859fd0 100644
--- a/poly/src/polynomial/univariate/dense.rs
+++ b/poly/src/polynomial/univariate/dense.rs
@@ -285,14 +285,6 @@ impl<F: Field> DerefMut for DensePolynomial<F> {
     }
 }
 
-impl<F: Field> Add for DensePolynomial<F> {
-    type Output = DensePolynomial<F>;
-
-    fn add(self, other: DensePolynomial<F>) -> Self {
-        &self + &other
-    }
-}
-
 impl<'a, 'b, F: Field> Add<&'a DensePolynomial<F>> for &'b DensePolynomial<F> {
     type Output = DensePolynomial<F>;
 
@@ -487,15 +479,6 @@ impl<'a, 'b, F: Field> Sub<&'a DensePolynomial<F>> for &'b DensePolynomial<F> {
     }
 }
 
-impl<F: Field> Sub<DensePolynomial<F>> for DensePolynomial<F> {
-    type Output = DensePolynomial<F>;
-
-    #[inline]
-    fn sub(self, other: DensePolynomial<F>) -> DensePolynomial<F> {
-        &self - &other
-    }
-}
-
 impl<'a, 'b, F: Field> Sub<&'a SparsePolynomial<F>> for &'b DensePolynomial<F> {
     type Output = DensePolynomial<F>;
 
@@ -593,15 +576,6 @@ impl<'a, 'b, F: Field> Div<&'a DensePolynomial<F>> for &'b DensePolynomial<F> {
     }
 }
 
-impl<F: Field> Div<DensePolynomial<F>> for DensePolynomial<F> {
-    type Output = DensePolynomial<F>;
-
-    #[inline]
-    fn div(self, divisor: DensePolynomial<F>) -> DensePolynomial<F> {
-        &self / &divisor
-    }
-}
-
 impl<'b, F: Field> Mul<F> for &'b DensePolynomial<F> {
     type Output = DensePolynomial<F>;
 
@@ -647,13 +621,35 @@ impl<'a, 'b, F: FftField> Mul<&'a DensePolynomial<F>> for &'b DensePolynomial<F>
     }
 }
 
-impl<F: FftField> Mul<DensePolynomial<F>> for DensePolynomial<F> {
-    type Output = DensePolynomial<F>;
+macro_rules! impl_op {
+    ($trait:ident, $method:ident, $field_bound:ident) => {
+        impl<F: $field_bound> $trait<DensePolynomial<F>> for DensePolynomial<F> {
+            type Output = DensePolynomial<F>;
 
-    #[inline]
-    fn mul(self, other: DensePolynomial<F>) -> DensePolynomial<F> {
-        &self * &other
-    }
+            #[inline]
+            fn $method(self, other: DensePolynomial<F>) -> DensePolynomial<F> {
+                (&self).$method(&other)
+            }
+        }
+
+        impl<'a, F: $field_bound> $trait<&'a DensePolynomial<F>> for DensePolynomial<F> {
+            type Output = DensePolynomial<F>;
+
+            #[inline]
+            fn $method(self, other: &'a DensePolynomial<F>) -> DensePolynomial<F> {
+                (&self).$method(other)
+            }
+        }
+
+        impl<'a, F: $field_bound> $trait<DensePolynomial<F>> for &'a DensePolynomial<F> {
+            type Output = DensePolynomial<F>;
+
+            #[inline]
+            fn $method(self, other: DensePolynomial<F>) -> DensePolynomial<F> {
+                self.$method(&other)
+            }
+        }
+    };
 }
 
 impl<F: Field> Zero for DensePolynomial<F> {
@@ -668,6 +664,11 @@ impl<F: Field> Zero for DensePolynomial<F> {
     }
 }
 
+impl_op!(Add, add, Field);
+impl_op!(Sub, sub, Field);
+impl_op!(Mul, mul, FftField);
+impl_op!(Div, div, Field);
+
 #[cfg(test)]
 mod tests {
     use crate::{polynomial::univariate::*, GeneralEvaluationDomain};

From 4f14ebe58d061f736611e9f7847325cbdab698db Mon Sep 17 00:00:00 2001
From: Cesar199999 <cesar.descalzo2@gmail.com>
Date: Wed, 26 Jun 2024 11:16:39 +0200
Subject: [PATCH 4/5] Undonde smaller breaking change
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Co-authored-by: Antonio Mejías Gil <anmegi.95@gmail.com>
---
 poly/src/polynomial/univariate/dense.rs | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/poly/src/polynomial/univariate/dense.rs b/poly/src/polynomial/univariate/dense.rs
index dca859fd0..5b9ba4643 100644
--- a/poly/src/polynomial/univariate/dense.rs
+++ b/poly/src/polynomial/univariate/dense.rs
@@ -593,15 +593,6 @@ impl<'b, F: Field> Mul<F> for &'b DensePolynomial<F> {
     }
 }
 
-impl<F: Field> Mul<F> for DensePolynomial<F> {
-    type Output = DensePolynomial<F>;
-
-    #[inline]
-    fn mul(self, elem: F) -> DensePolynomial<F> {
-        &self * elem
-    }
-}
-
 /// Performs O(nlogn) multiplication of polynomials if F is smooth.
 impl<'a, 'b, F: FftField> Mul<&'a DensePolynomial<F>> for &'b DensePolynomial<F> {
     type Output = DensePolynomial<F>;

From ee19e232c2f4922635ef8b6c0ff9531fce039494 Mon Sep 17 00:00:00 2001
From: Cesar199999 <cesar.descalzo2@gmail.com>
Date: Wed, 26 Jun 2024 09:33:01 +0200
Subject: [PATCH 5/5] Add non-reference scalar multiplication
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Co-authored-by: Antonio Mejías Gil <anmegi.95@gmail.com>
---
 poly/src/polynomial/univariate/dense.rs | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/poly/src/polynomial/univariate/dense.rs b/poly/src/polynomial/univariate/dense.rs
index 5b9ba4643..dca859fd0 100644
--- a/poly/src/polynomial/univariate/dense.rs
+++ b/poly/src/polynomial/univariate/dense.rs
@@ -593,6 +593,15 @@ impl<'b, F: Field> Mul<F> for &'b DensePolynomial<F> {
     }
 }
 
+impl<F: Field> Mul<F> for DensePolynomial<F> {
+    type Output = DensePolynomial<F>;
+
+    #[inline]
+    fn mul(self, elem: F) -> DensePolynomial<F> {
+        &self * elem
+    }
+}
+
 /// Performs O(nlogn) multiplication of polynomials if F is smooth.
 impl<'a, 'b, F: FftField> Mul<&'a DensePolynomial<F>> for &'b DensePolynomial<F> {
     type Output = DensePolynomial<F>;