Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error raised when there are no load shapes in the model #99

Open
AadilLatif opened this issue Apr 6, 2022 · 2 comments
Open

Error raised when there are no load shapes in the model #99

AadilLatif opened this issue Apr 6, 2022 · 2 comments

Comments

@AadilLatif
Copy link
Collaborator

SInterval for all LoadShapes must be the same: []

@AadilLatif
Copy link
Collaborator Author

@daniel-thom NMSU is playing around with pydss and ran into this issue.

I implemented a tiny workaround to get the simulation going. QSTS with no profile does not make sense but we can be using the external profile manager so a little confused on what the path forward should be

if len(set(res)):
if len(set(res)) != 1:
raise InvalidConfiguration(
f"SInterval for all LoadShapes must be the same: {res}"
)
return res[0]
else:
return 1

@daniel-thom
Copy link
Collaborator

@AadilLatif Your fix would work. This function is only getting called in order to handle the load shape offset issue. A few months ago I added a simulation settings option to disable that behavior by default. Refer to 14fd947 in the merge-gemini branch and settings.project.use_loadshape_offset_workaround. It makes the user opt in to working around this problem. That would avoid this problem altogether.

Perhaps we should merge whatever we need from that branch into master? My team has been impacted by that offset issue. We can always be sure to opt in to the workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants