Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CEC Code warnings dev branch #516

Closed
shirubana opened this issue May 21, 2024 · 2 comments · Fixed by #527
Closed

CEC Code warnings dev branch #516

shirubana opened this issue May 21, 2024 · 2 comments · Fixed by #527
Labels
v0_5_0 Include for v0.5.0 release

Comments

@shirubana
Copy link
Member

image
@shirubana
Copy link
Member Author

hi @cdeline ~ getting this warnings with our new fancy python :) just saw you're poking around on warnings, in case you can fix this it would clear a lot of nonsense warnings :D

shirubana added a commit that referenced this issue Jun 18, 2024
@shirubana
Fix Warning #516
a579479 
Fixes warning to 516 on performance and mismatch calculations trying to floatize a value that is actually a dataframe. Left it with a if statement in case a dictionary is passed directly (I think that's one of our cases... maybe... we'll see if the pytest breaks :D )
@cdeline cdeline added the v0_5_0 Include for v0.5.0 release label Aug 20, 2024
@cdeline
Copy link
Contributor

cdeline commented Aug 21, 2024

Which example notebook is this happening on? I'm not able to replicate it, and your proposed fix in development is breaking. I'm reverting this back and we can take it off into side branch 516

cdeline added a commit that referenced this issue Aug 21, 2024
@cdeline
Enclose file names used for radfiles in quotes. Fixes #523. CEC perfo…
1cfc40a 
…rmance bugfix. Fixes #516.
@cdeline cdeline mentioned this issue Aug 21, 2024
Merged
cdeline added a commit that referenced this issue Aug 21, 2024
@cdeline
Merge pull request #527 from NREL/516_CEC_Warnings
d327014 
Enclose file names used for radfiles in quotes.  Fixes #523.  Fixes #516
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v0_5_0 Include for v0.5.0 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enclose file names used for radfiles in quotes. Fixes #523. NREL/bifacial_radiance
2 participants
@shirubana @cdeline