Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResStock-HPXML: detailed bill calcs #382

Merged
merged 10 commits into from
Oct 10, 2023
Merged

ResStock-HPXML: detailed bill calcs #382

merged 10 commits into from
Oct 10, 2023

Conversation

joseph-robertson
Copy link
Contributor

@joseph-robertson joseph-robertson commented Jul 25, 2023

Pull Request Description

See NREL/resstock#1109 for context.

Also addresses #381.

Checklist

Not all may apply

  • Code changes (must work)
  • Tests exercising your feature/bug fix (check coverage report on Checks -> BuildStockBatch Tests -> Artifacts)
  • Coverage has increased or at least not decreased. Update minimum_coverage in .github/workflows/ci.yml as necessary.
  • All other unit and integration tests passing
  • Update validation for project config yaml file changes
  • Update existing documentation
  • Run a small batch run on Eagle to make sure it all works if you made changes that will affect Eagle
  • Add to the changelog_dev.rst file and propose migration text in the pull request

@joseph-robertson joseph-robertson self-assigned this Jul 25, 2023
@joseph-robertson joseph-robertson marked this pull request as ready for review July 25, 2023 23:35
@github-actions
Copy link

github-actions bot commented Aug 16, 2023

File Coverage
All files 84%
base.py 89%
eagle.py 79%
exc.py 57%
local.py 50%
postprocessing.py 84%
utils.py 96%
sampler/base.py 79%
sampler/downselect.py 33%
sampler/precomputed.py 93%
sampler/residential_quota.py 61%
test/test_docker.py 33%
test/test_validation.py 97%
workflow_generator/base.py 90%
workflow_generator/commercial.py 53%
workflow_generator/residential_hpxml.py 84%

Minimum allowed coverage is 33%

Generated by 🐒 cobertura-action against 47452b2

Copy link

@yingli-NREL yingli-NREL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a testing. This environment works well for calculating detailed bills.

@nmerket nmerket added this to the v2023.10.0 milestone Oct 3, 2023
Copy link
Member

@nmerket nmerket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also looks good. Pop in a changelog entry and I'll merge it.

@nmerket nmerket merged commit 431cd92 into develop Oct 10, 2023
6 checks passed
@nmerket nmerket deleted the detailed-bill-calcs branch October 10, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants