Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resilience arguments to yml files #1113

Merged
merged 16 commits into from
Oct 24, 2023
Merged

Conversation

joseph-robertson
Copy link
Contributor

@joseph-robertson joseph-robertson commented Aug 1, 2023

Pull Request Description

Include the new include_timeseries_resilience argument in example yml files.

Checklist

Not all may apply:

  • Tests (and test files) have been updated
  • Documentation has been updated
    • If related to resstock-estimation, checklist includes data dictionary, source report, options_lookup
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected regression test changes on CI (checked comparison artifacts)

@joseph-robertson joseph-robertson added this to the ResStock v3.2.0 milestone Aug 1, 2023
@joseph-robertson joseph-robertson self-assigned this Aug 1, 2023
@joseph-robertson joseph-robertson marked this pull request as ready for review October 17, 2023 21:44
@jmaguire1
Copy link
Contributor

jmaguire1 commented Oct 18, 2023

One thought/suggestion for resilience: there's a pretty non obvious thing you should change when looking at resiliency. There's a "temperature capacitance multiplier" (TCM) input in E+ that increases the thermal mass of the air node. If you just stick with the default we have right now (1.0), you'll see the building temperature increase/decrease faster than appears realistic. Looking at the literature, when people are calibrating models there isn't much consensus on what value should be used, there's a range between 3-15 depending on the building. I've been using a value of 7.0, based on what's worked well in the projects we've run, where we ran HIL experiments in SPL and tried to calibrate to a real building by changing the TCM.

@shorowit
Copy link
Contributor

@jmaguire1 Why would the battery resilience metric be significantly affected by the temperature capacitance multiplier? We're not modeling power outages to calculate it, we're just seeing how long the battery would last under normal electricity usage conditions.

@jmaguire1
Copy link
Contributor

@shorowit: Oops, I misunderstood what this PR was doing. I was thinking this had to do with outages, not just adding the battery resilience metric. I am curious about TCM with outages in ResStock, but that really should be a separate discussion from this PR.

@joseph-robertson joseph-robertson merged commit 11c0794 into develop Oct 24, 2023
@joseph-robertson joseph-robertson deleted the yml-resilience-args branch October 24, 2023 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants