Test https://github.com/NREL/OpenStudio/pull/5194

[joseph-robertson]

Pull Request Description

[description here]

Checklist

Not all may apply:

• Tests (and test files) have been updated
• Documentation has been updated
  • If related to resstock-estimation, checklist includes data dictionary, source report, options saturation, options_lookup.
• Changelog has been updated
• openstudio tasks.rb update_measures has been run
• No unexpected regression test changes on CI (checked comparison artifacts)

[jmarrec]

I can consistently reproduce the crash, but it's weeeeeeeeeeird.

Using a docker, I ran

bundle install
sed -i -e 's/[[:space:]]*$//' resources/options_lookup.tsv # Remove whitespace
(sed -u 1q ; sort -k1 -k2) < resources/options_lookup.tsv > sorted_options_lookup.tsv
mv sorted_options_lookup.tsv resources/options_lookup.tsv # Sort on first two columns
openstudio workflow/run_analysis.rb -y project_testing/testing_upgrades.yml

Then I kept only testing_upgrades/buildstock.csv and modified the project_testing/testing_upgrades.yml to be

output_directory: testing_upgrades/output

sampler:
  type: precomputed
  args:
    sample_file: ../testing_upgrades/buildstock.csv

I also kept only two measures in the upgrades

That way I can consistently run the same datapoints via

openstudio workflow/run_analysis.rb -y project_testing/testing_upgrades.yml --keep_run_folders --debug -i 1 --threads 1

• I can only reproduce the crash using a docker. If I run the same on my native ubuntu 20.04 machine, it does not crash!
• I was trying to isolate the issue by dumping the runner.workflow before the crash by inserting a line just before

  resstock/measures/UpgradeCosts/measure.rb

  Line 74 in b44ce2d

  apply_upgrade = runner.getPastStepValuesForMeasure('apply_upgrade') # FIXME: this causes a segfault for some reason

  • Either runner.workflow.saveAs('CURRENT_WORKFLOW.osw') or File.write("CURRENT_WORKFLOW.osw", runner.workflow.to_s)
  • Weirdly enough, if I do that,the crash is gone 🤷

[jmarrec]

I tried dumping the OSW instead in the ReportUtilityBills.rb measure (at the end of the run() I added runner.workflow.saveAs('../report_utility_bills_CURRENT_WORKFLOW.osw'))

The crash still happens in docker.

But if I pop into an irb/pry session and load it, no crash

require 'openstudio'
w = OpenStudio::WorkflowJSON.new('testing_upgrades/output/run2/run/report_utility_bills_CURRENT_WORKFLOW.osw')
runner = OpenStudio::Measure::OSRunner.new(w)
runner.getPastStepValuesForMeasure('apply_upgrade')
=> {:option_01_cost_1_multiplier_to_apply=>"Wall Area, Above-Grade, Conditioned (ft^2)",
 :option_01_cost_1_value_to_apply=>"2.21",
 :option_01_cost_2_multiplier_to_apply=>"",
[...]

[jmarrec]

Similarly, while I do see it crash with ruby launching

"/usr/local/openstudio-3.8.0-rc2/bin/openstudio" run -w "/var/simdata/openstudio/testing_upgrades/output/run2/testing_upgrades-Walls.osw"

If I issue the command myself in the docker, it works.