Latest OS-HPXML #1298
Merged
Latest OS-HPXML #1298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…95ea9ae dbc5c95ea9ae Merge pull request #1690 from NREL/nbr_vs_nocc_new_regressions 1dc7c5e86e27 Merge branch 'nbr_vs_nocc_new_regressions' of https://github.com/NREL/OpenStudio-HPXML into nbr_vs_nocc_new_regressions c068f61f0cab Fix tests, 10% tolerance is too high b71eb65858f4 Latest results. bf017c970c1b Update link ecae1cfff5a7 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into nbr_vs_nocc_new_regressions 84564d85a2a8 Merge pull request #1775 from NREL/plug_loads_operational_calc 5db44d46d53e Latest results. 5b529c03b860 Update Changelog.md [ci skip] cd5ef8f3e86f Fix/update docs. db640d4f0878 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into plug_loads_operational_calc 07fc18724e2f Merge pull request #1685 from NREL/floor_height_above_grade bf87d6caa64b Handle possibility of negative values. d17b4470d6dc Latest results. 58371b285ad7 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into floor_height_above_grade e09009152c97 Latest results. b78e17e5c5ee First pass. 8478660e712e Latest results. c24117a415a2 Update name. ed3059d3b11d Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into floor_height_above_grade 0be1bc0f0a22 Latest results. 1c250ade59da Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into nbr_vs_nocc_new_regressions 22ef795fa104 Reverting back to previous NBr/N_occ relations. 58b712adfd32 Latest results. 408c4b6f3aad Test failures addressed. 0d7ce5cf9f55 New regression equations added from RECS 2020 for N_Bedrooms Vs N_Occupants - also segregating building types to higher granularity 7bc5dd7d3668 Latest results. 2c4ac5e7c923 Merge branch 'floor_height_above_grade' of https://github.com/NREL/OpenStudio-HPXML into floor_height_above_grade 89c213c6491e Small bugfix. c831575637ca Latest results. 922d4aef5631 Fix 10x tests when there are negative numbers. 70b653992588 Fix sample file, update Changelog.md. 8f0bae834a12 First pass on implementing floor height above grade as an input that can be used in the infiltration model for e.g. apartment units on upper levels. git-subtree-dir: resources/hpxml-measures git-subtree-split: dbc5c95ea9ae7f3bf8af7205efeb3b110aa67c16
… is now defaulted.
You might consider setting a value in ResStockArguments for apartment units based on the type/size of MF building and where the unit is located (lower, middle, or upper story). |
…7496f27 55d707496f27 Fix typos. git-subtree-dir: resources/hpxml-measures git-subtree-split: 55d707496f273c3c46ad0f9e98a67deaca4d68dc
Probably more straightfoward for upper vs middle story (where there could be multiple middle stories)? |
First step might be to try different heights (e.g., 0, 8, ..., 24) to understand how much impact this has. Then could think about using average values for different building heights. |
…7167430 7c4d47167430 Merge pull request #1823 from NREL/more_bob_ross_cases d74db37a1ede Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into more_bob_ross_cases 4c15e9960932 Hotfix to address warning [ci skip] a90c9ab5e16c Merge pull request #1824 from NREL/refactor_default_wh_location 672bf87b8962 Update docs 4b905c05137c Minor refactor of Waterheater.get_default_location method to simplify the arguments. 80b39ec2b12a Merge pull request #1822 from NREL/reduce-advanced-feature-simulations 1c2e9bb48afe Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into reduce-advanced-feature-simulations 4362479261bd Latest HPXML schema. de2a7767b15d Latest results. 78c464b7e61d Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into reduce-advanced-feature-simulations 0370ffb18eb8 fix unit test e06607e7395a Update methods to be backwards-compatible. 8bb6e6cafe45 update measures 40bd2abf84e9 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into reduce-advanced-feature-simulations ad00017bff1b Added 2 speed system test file back, changed var speed system test file to be hourly a2e73a11f336 Latest results. eacd3b5902b5 Added more Bob Ross test cases. 5dde4bb4ebb5 Latest results. 7202d1bbe016 Reduce number of sample files with 1-minute timesteps to speed up CI jobs. git-subtree-dir: resources/hpxml-measures git-subtree-split: 7c4d47167430cd0015ec131892887b2915652c5e
…e9829d3 9e3f9e9829d3 Merge pull request #1833 from NREL/zipcode_tmy3 9a3749e3c1aa A little more error-checking and cleanup. 187e174229da Stopped trying to be too clever by half. 96858af017c4 Bugfix. 45c0ddc73019 Latest results. c4091863db2c Simplify code 489c0a5c665c Bugfix and cleanup. 553cae2bd7ca Fix 7/8 CZs c721b7a024f5 Refactor: Combine all the weather station lookups into a single file. 39fe5a9e70a4 A little more cleanup. 81741517831a Bugfix and made it even faster. f889608b41dd Update docs/changelog. Minor cleanup. 787d32df361b Fix tests. c259099da404 Clean up 38d28915b371 Add a couple tests. 8f7c53d69ed5 Allow zipcode to be provided instead of epw file/path, in which case we default to the nearest TMY3 EPW. git-subtree-dir: resources/hpxml-measures git-subtree-split: 9e3f9e9829d31670f8181ec3629c3db74f49fa4f
…ec16901 11bb6ec16901 Merge pull request #1829 from NREL/no-hvac-season 5614d3aebac6 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into no-hvac-season 12dbaf5e0f27 Bugfix 26e99e6f1245 Make code consistent with recent refactored code. 640cc1009a01 Merge pull request #1834 from NREL/lixi_docs e7196628f683 Merge branch 'master' into no-hvac-season 70b071968a8e Make natvent availability argument optional. 75220943c4e4 Merge pull request #1817 from NREL/ruby-docs 9896e0e2f4c0 Latest results. 27ebe4e8d7ab Minor updates. c837fdfcf3f5 Move setpoints code back to the beginning. 488e01ba03f9 Merge branch 'master' into no-hvac-season 7f0223184089 Bugfix for CI regression. cf8138c38a5c Merge branch 'ruby-docs' of https://github.com/NREL/OpenStudio-HPXML into ruby-docs 6db81ef46149 Final pass. Reorganized measure.rb into additional methods and some misc cleanup. d4e0b7998776 Latest results. 07813e6a4e88 Bugfix. 0741681d8d3d Final pass for now (hot water and airflow). 5a5a1ca1099a Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into ruby-docs 579ff80f2fc5 Merge branch 'ruby-docs' of https://github.com/NREL/OpenStudio-HPXML into ruby-docs cb20947186c1 Huge pass on moving code out of measure.rb, cleanup. 59b6bd2b7f0d Merge pull request #1827 from NREL/Bob_Ross_del_4_5 06af1c933c7e Latest results. 15997847e51b Update 3-19 per ACCA bdfc82639306 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into Bob_Ross_del_4_5 d779bddf281b Merge branch 'master' into no-hvac-season f1c9f1d2dfb9 Merge branch 'master' into ruby-docs 232ddcdb843d Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into ruby-docs 1e599dc4b7f0 Latest results. 5e74300cce62 Update the changelog. [ci skip] 78eb6420790d Revert previous approach and update sample files. 963f14b2f8a6 A bit more explanation [ci skip] 2016d15b0da4 Clarify some docs based on comments from @lixilui. adff70b2abbf Update measures and sample files. 443e7cf6e54b Change unavailable period arguments. 9d6fb6fa1515 Latest results. cdcb1b0424b0 Update new sample file and workflow test. d77027c5ada6 Add a sample file that demonstrates the change. dfe659637f89 Update get_daily_season calendar resource method. 67bd7a8da7d3 Update build measure season argument descriptions. 1b01ddb02e53 Merge branch 'master' into ruby-docs 6d8db39c20dd Latest results. 371218136c8b Latest results. 0ca21dc52211 Merge branch 'more_bob_ross_cases' of https://github.com/NREL/OpenStudio-HPXML into Bob_Ross_del_4_5 bbeb5b05b39d added del4&5 test files 6f2442044384 More method name updates. 6fb35e54d7e5 Merge branch 'master' into ruby-docs 30dc01a201a6 Move translator methods to new internal_gains and model resource files. 7c4729b2f588 Merge branch 'master' into ruby-docs f7858574b57d Relocate airflow related create_ducts method. 38763d5d32e5 Continue to relocate constructions and geometry related methods. e50348fb38ef Must have add_setpoints before enclosure. 08f8c95ff9a4 Clean up and refactor methods called from create_unit_model. 74264da49dab Progress. f640608de8ce Merge branch 'master' into ruby-docs 07e436e14016 Start relocating translator methods to resource files. git-subtree-dir: resources/hpxml-measures git-subtree-split: 11bb6ec16901c62b3d6e3c2b7a5cc4efde426971
…3c39e30 623f63c39e30 Merge pull request #1825 from NREL/fix_advanced_defrost_small_capacity 58bb02bbcd7d Update HPXMLtoOpenStudio/resources/hvac.rb 5baaee81eb95 update_measures 7243322727a7 Merge branch 'fix_advanced_defrost_small_capacity' of https://github.com/NREL/OpenStudio-HPXML into fix_advanced_defrost_small_capacity aab9cdb48e22 address comments 29218311e3a0 Update HPXMLtoOpenStudio/resources/hvac.rb 8d3eb0488441 rerun update measures 9fef7e18f403 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into fix_advanced_defrost_small_capacity 88e256c9f0be Merge pull request #1838 from NREL/update_openei_rates 27c68d02692f Cleanup. [ci skip] a85a4be98b1a Update Changelog.md 54a064d57d48 Pulls the latest residential URDB rates. 7a073c925974 Merge pull request #1837 from NREL/airflow_cleanup c19643c0c637 Some additional cleanup of hpxml_defaults.rb. 89db6c2867bc Airflow.rb cleanup: remove globals, simplify passed arguments, etc. 0d8be0fe07e2 Merge pull request #1836 from NREL/fix_partial_outputs 3f8efb3bea16 Bugfix. 260f10fdcbe0 Bugfix. d4bd5e0047fb Reorganizes code so that output files are written last in the HPXMLtoOpenStudio measure. 66e2c72c3aa2 update measures bdfa6edec441 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into fix_advanced_defrost_small_capacity 340ddfe2ba05 add unit test 24739211221a Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into fix_advanced_defrost_small_capacity ef3a5bd98516 update measures 81b24a01b7ac update source code docs related to advanced defrost 1c61091eaf33 propose a solution to avoid negative p_dot when cooling capacity is too small git-subtree-dir: resources/hpxml-measures git-subtree-split: 623f63c39e30116e746e55cde69044dfc9cdbf7e
…c9d9ac6 4143ec9d9ac6 Merge pull request #1707 from NREL/adp_bf_method_design_shr d31578420040 Cleanup comments. 5efcc61504c1 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into adp_bf_method_design_shr 56a871350a3c Latest results. 50c9c7d181fe Unrelated code cleanup c6435fab6ee6 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into adp_bf_method_design_shr 12fee3415656 measure.xml updated after running RuboCop. no offenses detected, measure.xml gets overwritten by CI anyway 4779ada0bda8 changed variable name from hvac_cooling_shr to hvac_cooling_shr_rated in apply_hvac_equipment_adjustments; cosmetic change only a71a1165d6d3 accepting incoming master to get adp branch up to date 1c418dc882ab succesfully ran Rubocop 5df10ebe0867 pulling in master after addressing adp_bf review comments 9c683e7fd8c2 running Rubocop 40f3831b3a98 adding comments re a_o_rated to address Jon Winkler review comment 2 cb5e1d1f0ec0 adding informative messages to design airflow calculation for central cooling equipment 0692d10ae53c concluded merge from diverging local and origin adp_bf_branches 178f5da6b618 addressing first Jon W. comment re adp_bf review 18cf4138d83e Latest results. 49372e7ac812 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into adp_bf_method_design_shr 0a7b1f3a41cf fixes to get_hvac_size_limits to ensure adp_bf_branch runs without error 18f106b82c56 descriptive comments on get_hvac_size_limits ce0994b905ec / \ line extension + divisor in hvac_sizing.rb 50bb97246a7d Latest results. a7d7e4158fe1 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into adp_bf_method_design_shr 8b9416491085 successful? merge of latest master into adp_bf_method_design_shr to update changes re. negative elevation fix. looking thru modified files shows no merge conflict indicators (<<<, >>>). 237309723fe8 updating comments on HVACSizingValues attributes to match master. No attributes added, only changes were in the comments next to each attribute 1d3a43a518a8 changing comments on get_nominal_speed method to match remote master 547cf7f83868 removing :Design_SHR property from HVACSizingValues class definition, since it is no longer used c07cb1735635 refactor to rename hvac_sizings.Design_SHR object property to local variable design_shr d373f6eb0c23 Latest results. 776661a9636b manually resolved merge conflicts in results.csv 599ec246d461 resolved merge conflicts in measure.xml ba79c8ab1b2c adp_bf_method branch up to date w/ master, merge conflicts resolved manually, final commit before submitting PR for review 2de64ea1d79f last explanatory comment before marking adp_bf_method PR for review 14f36ebf4298 removing puts statements before PR review 1edc8225027c Latest results. 49fd10522475 Re-enable test, remove files. 0b0cc26ee94a Merge branch 'master' into adp_bf_method_design_shr f59824199047 correct hvac_sizing and removing duplicated HPXMLtoOpenStudio directory that was incorrectly copied to docs folder 83d3094c38b0 hvac_sizing.rb, measure.xml, and docs updates after running RuboCop 4d5cecab8270 remove unit test for Psychrometrics.CalculateSHR(), since test_error.xml is now running without error f66028610684 test_error.xml running without failure. haven't inspected annual or timeseries results yet. change was to calculated A_o at rated conditions (using class variables in hvac.rb for IDB, IWB, and using psychrometrics.rb helper function for rated indoor clg humidity ratio at sea level barometric pressure (not sure pressure is correct, confirm w/ Jon?), and pass this into CoilAoFactor. CoilAoFactor should stay constant throughout the iteration for design airflow. 38cb97108a71 added files after git restore HPXMLtoOpenStudio to recover HPXMLtoOpenStudio folder lost on local 487c702b855d defined test_calculate_SHR() in hvac_sizing_test.rb 315916fa7006 Latest results. 400a43f629c5 Temporarily disable test to get CI results. a887009ac1cb Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into adp_bf_method_design_shr 8f4b83daa60a Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into adp_bf_method_design_shr 308c1f754470 Fix error and minor refactoring. 3f8f26d77ab0 confident in ADP/BF 1ca7c4a3564b finished writing code for ADP/BF implementation. ADP/BF method is a better approach to calculating the design SHR and design airflow through the cooling coil for the following OS-HPXML equipment types: Central AC, A2A HP used for cooling, Mini-Split AC, and ducted MSHP used for cooling b177cb986673 more work on iteration for design airflow f0d925c05168 more comments c721a0185ba1 iteration for ADP/BF 26a55b36c6e1 fixed unit conversion on cool_cap_rated so that Psychrometrics.rb doesn't numerically fail. hvac_cooling_ap.rated_shr and hvac_cooling_shr showing 0.05 discrepancy. ask team if this is a problem? d37f8c146ae3 using pre-existing coil ao factor stored in cooling additional properties to calculate design SHR. Cool Cap Design throwing undefined variable error in Psychrometrics.CalculateSHR 85b2e27f7027 work on implementing ADP/BF. coil a_o factor already calculated in hvac.rb? 0391906f9b5f Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into adp_bf_method_design_shr 74bb5facff04 removing pesky return 1.0 that shouldn't be there, preventing it from screwing things up when running OS CLI f9ed1b8a5fda fixed typo in descriptive comments of psychrometrics.rb 79053154feb9 fixed typo in comments of CoilAoFactor method in psychrometrics.rb 1e3ef9a3b190 refactor add_cooling_system function variable input order convention to match add_heating_system function variable input order convention 2cdde89a4b3e renamed A_o from A_o rated because A_o is not a function of design vs. rated conditions c1a78271fdc4 calculating A_o_rated with correct unit conversions and methods in psychometrics.rb af5834552994 Translating E+ coil bypass factor method to recalculate cool_cap_design 6861e467a607 Merge branch 'master' into adp_bf_method_design_shr 2aca92f61615 Committing comments for ADP/BF 49e998de659d hvac_sizing.rb af484e8b5ae2 adding explanatory comments 82e23b660b77 Merge remote-tracking branch 'origin/master' into acca_manual_s 1ac11a24d63c adding comment on apply_equipment_adjustments 698aaf46a387 Committing pseudo_code_heat_pump_sizing.txt to branch OS_ACCA_Man_S_update git-subtree-dir: resources/hpxml-measures git-subtree-split: 4143ec9d9ac6ec71c9848d836dfa942c2665b664
|
In ResStock, when do we use the unadjusted number of bedrooms? |
Setting the number of bedrooms is not only a required HPXML field, but it is an input for ACCA Manual J design loads. |
…159defd 990df159defd Merge pull request #1842 from NREL/mj_default_num_occupants cb81e54ff866 Latest results. 7f691f6b73ac Fixes #1841. 845b6ab238e3 Merge pull request #1826 from NREL/exterior_shading_type 1188edd421b3 Final cleanup. e8e3a7c2c53f Latest results. 7abe0eeb0e41 Docs bugfix c570c031b742 Bugfix. 5fe0bbb9d89d Simplify things. ca62509039f2 Latest results. e63fddf68d1c Allow interior shading type=none. Allow exterior shading coverage fractions. de7b116ff968 Latest results. 74dee378c31d Add warnings and tests. 6da575f8e4dc Latest results. 57546ff6774b Update expected test values. 51e898be9668 Merge branch 'exterior_shading_type' of https://github.com/NREL/OpenStudio-HPXML into exterior_shading_type 1c4b872f4eb9 Allow more decimal places to reduce diffs. 0484abbd14b7 Latest results. 94f1959a91b4 Fix test c3903e4866ed Update ACCA test files. 522b711cfb42 Merge branch 'exterior_shading_type' of https://github.com/NREL/OpenStudio-HPXML into exterior_shading_type a1c7142156c7 Add new BuildResHPXML measure arguments. Update defaults for blinds. Expand sample files. cc68cc78d1aa Latest results. c845338cf610 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into exterior_shading_type 16a4b844f284 Latest results. 52b5a1106004 Bugfix, cleanup. 76192028fa65 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into exterior_shading_type 3ad40c940527 First big pass on interior shading inputs. e924f92f9f95 Latest results. 0916e18529d5 Update tests. 3067f718cec1 Add inputs for insect screen shading coefficients. Tweaks some defaults to be more conservative. 531843bff9c6 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into exterior_shading_type fc3ed5feeadf Latest results. 7cf294647a82 Fix docs. c656f967e6f6 Update new HPXMLs a476ce591e6e Merge branch 'Bob_Ross_del_4_5' of https://github.com/NREL/OpenStudio-HPXML into exterior_shading_type 2141d55abb45 Fix error, clean up docs. 5152fb6ac31c First pass on allowing Window/InsectScreen. b0b91e4df78f Latest results. 0bb224872414 Update file names. f6915b02fda7 Use ref in docs. a263002e3cf3 First pass on allowing Window/ExteriorShading/Type. git-subtree-dir: resources/hpxml-measures git-subtree-split: 990df159defd11a9498592292e23b94ca4f06201
…b792496 69b9cb792496 Merge pull request #1844 from NREL/avoid_csv_library 7f06505e8c12 Update comment for consistency [ci skip] e6ab5eabfc62 Might as well do it here too for consistency. fba96d4069c7 Speeds up reading/writing/processing detailed schedule files and writing CSV timeseries output by avoiding the CSV library. c9f71f3b699b Merge pull request #1843 from NREL/mj_num_occ_double 69f1aca26537 Latest results. e77151ef09b2 Update test ba479b5ed452 Update HPXMLs daa67c6d09f5 Adds a test case with a non-integer number of residents. Converts Manual J Num Occupants inputs from integer to double to fix a possible error. git-subtree-dir: resources/hpxml-measures git-subtree-split: 69b9cb7924965add4b1114de5d32d97131ffe152
You might consider using them instead of summer/winter coefficients. They interact with window type (SHGC), whereas the coefficients have no interaction. Though it will be a definite change from what ResStock is doing today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Pulls in:
UnitHeightAboveGradeinput for infiltration model OpenStudio-HPXML#1685geometry_unit_height_above_grade=autounder Geometry Building Type RECS in options_lookupschedules_unavailable_period_xxxarguments using oldschedules_vacancy_periods,schedules_power_outage_periods, andschedules_power_outage_periods_window_natvent_availabilityarguments that are assigned in the lookupInteriorShading/Type,ExteriorShading/Type, andInsectScreenOpenStudio-HPXML#1826window_interior_shading_type,window_exterior_shading_type, andwindow_insect_screensto the lookup but set them all toautoHVACSizingControl/ManualJInputs/NumberofOccupantsOpenStudio-HPXML#1842Checked means that something in resstock was changed or updated as a result of pulling in.
Other plug loads change for MH:
Television plug loads change for all building types:
Some occupant-driven end uses (pool, spa, range/oven, well pump, gas grill/fireplace/lighting, etc) increase:
Checklist
Not all may apply:
Tests (and test files) have been updatedIf related to resstock-estimation, checklist includes data dictionary, source report, options saturation, options_lookup.openstudio tasks.rb update_measureshas been run