Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wordpress integration #1

Open
JoeGermuska opened this issue Mar 21, 2016 · 5 comments
Open

Wordpress integration #1

JoeGermuska opened this issue Mar 21, 2016 · 5 comments
Assignees

Comments

@JoeGermuska
Copy link
Member

this isn't really an issue with this server, but this seems like the easiest place to document things.

We can add ourselves to the Wordpress whitelist here:

https://github.com/WordPress/WordPress/blob/master/wp-includes/class-oembed.php

this will solve the discovery problems for TimelineJS and Juxtapose.

@bomanimc
Copy link
Collaborator

Hey Joe. I'm not sure how we go about getting Knight Lab added to the list. Do we just submit a pull request adding our URL to that file?

@JoeGermuska
Copy link
Member Author

I thought maybe, but looks like not. From the homepage of the Wordpress git repo:

WordPress, Git-ified. Synced via SVN every 15 minutes, including branches and tags! This repository is just a mirror of the WordPress subversion repository. Please do not send pull requests. Submit patches to http://core.trac.wordpress.org/ instead. http://wordpress.org/

If you want to look into the right process for doing that, you're welcome to! Assign this issue to yourself if you do (if you can?)

@bomanimc
Copy link
Collaborator

Oh! I guess I assumed that you were assigning it to me. Actually, I'd probably prefer if you or someone else did this one haha.

@JoeGermuska
Copy link
Member Author

I submitted a Trac ticket https://core.trac.wordpress.org/ticket/36301

we'll see if they take it.

@JoeGermuska JoeGermuska self-assigned this Mar 22, 2016
@JoeGermuska
Copy link
Member Author

We are supposed to answer all the questions at https://make.wordpress.org/core/handbook/contribute/design-decisions/#whitelisting-oembed-providers

Odds are not great that we'll persuade them. It may be that we should simply write a wordpress plugin which registers our own oembed providers. It would be a super simple plugin to write, given what we've learned from the more elaborate Timeline/WP plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants