Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update alowed python versions for onnx-graphsurgeon #3781

Open
tadejsv opened this issue Apr 6, 2024 · 7 comments
Open

Update alowed python versions for onnx-graphsurgeon #3781

tadejsv opened this issue Apr 6, 2024 · 7 comments
Assignees
Labels
triaged Issue has been triaged by maintainers

Comments

@tadejsv
Copy link

tadejsv commented Apr 6, 2024

onnx-graphsurgeon only works with python versions up to 3.8. Please upgrade it to at least 3.10 - this is the Python version used in all latest Nvidia containers

@lix19937
Copy link

pip install nvidia-pyindex
pip install onnx-graphsurgeon

@lix19937
Copy link

lix19937 commented Apr 11, 2024

or https://developer.nvidia.com/tensorrt/download then unzip
This directory will have sub-directories like lib, include, data, and so on.

ls TensorRT-${version}   

bin  data  doc  include  lib  onnx_graphsurgeon  python  samples  targets

check the version of onnx_graphsurgeon

pip install onnx_graphsurgeon-0.5.1-py2.py3-none-any.whl

https://docs.nvidia.com/deeplearning/tensorrt/install-guide/index.html#installing-tar

@tadejsv
Copy link
Author

tadejsv commented Apr 11, 2024

Thanks, I don't want to download and unzip the file manually, I want to do it using pip so that I can properly specify my environment and resolve dependencies. Please fix the issue with missing versions in NVIDIA's python package index

@zerollzeng
Copy link
Collaborator

Checking internally.

@zerollzeng zerollzeng self-assigned this Apr 12, 2024
@zerollzeng zerollzeng added the triaged Issue has been triaged by maintainers label Apr 12, 2024
@zerollzeng
Copy link
Collaborator

onnx-graphsurgeon only works with python versions up to 3.8.

it should be python version agnostic, could you please provide a reproduce of the issue?
thanks!

@tadejsv
Copy link
Author

tadejsv commented Apr 14, 2024

onnx-graphsurgeon only works with python versions up to 3.8.

it should be python version agnostic, could you please provide a reproduce of the issue? thanks!

Yeah you're right - this was actually a problem with newer versions of onnx-graphsurgeon being available. However, you can still change.

However, it would be good to update classifiers in setup.py to the python versions actually supported:

"Intended Audience :: Developers",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.4",
"Programming Language :: Python :: 3.5",
"Programming Language :: Python :: 3.6",
"Programming Language :: Python :: 3.7",
"Programming Language :: Python :: 3.8",
],

@zerollzeng
Copy link
Collaborator

@pranavm-nvidia ^ ^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triaged Issue has been triaged by maintainers
Projects
None yet
Development

No branches or pull requests

3 participants