Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FP8 for norm inputs and residuals? #1193

Open
cbcase opened this issue Sep 21, 2024 · 0 comments
Open

FP8 for norm inputs and residuals? #1193

cbcase opened this issue Sep 21, 2024 · 0 comments

Comments

@cbcase
Copy link

cbcase commented Sep 21, 2024

Question for you guys: as best I can tell, there is no support at present for keeping activations in fp8 between the "output" matmul (of either an attention block or MLP block) and the next norm (layernorm or rmsnorm). The missing features to make that work are:

  • FP8 residual input/output (along with the necessary scales) to fp8 gemm
  • FP8 input (with scale) to {rms,layer}norm

Is this something you have considered, or is there a more fundamental limitation (kernel-wise or accuracy-wise) that means you always want to keep the residual path in a 16-bit format. (Fwiw, my own interest here is for inference.)

Thanks,
Carl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant