Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing nonexistent argument when flash_attn version is >= 2.5.7 #1213

Open
MaciejBalaNV opened this issue Sep 27, 2024 · 1 comment
Open

Comments

@MaciejBalaNV
Copy link

MaciejBalaNV commented Sep 27, 2024

In this place in TE we pass "block_table" argument to either flash_attn_func or flash_attn_varlen_func functions from flash_attn package. However, this function doesn't have this argument, only flash_attn_varlen_func function does, as we can verify here. I'm attaching HEAD of main as a link, but it's the same in version 2.5.8. It results in an error when flash_attn_func is chosen.

@MaciejBalaNV
Copy link
Author

Seems like this bug was added in this commit, which introduced support for FA3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant