Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

intra_domain_ranks is not defined in one of the execution paths. #1306

Closed
erhoo82 opened this issue Nov 2, 2024 · 1 comment · Fixed by #1305
Closed

intra_domain_ranks is not defined in one of the execution paths. #1306

erhoo82 opened this issue Nov 2, 2024 · 1 comment · Fixed by #1305
Assignees
@denera

Comments

@erhoo82
Copy link
Collaborator

erhoo82 commented Nov 2, 2024

intra_domain_ranks at https://github.com/NVIDIA/TransformerEngine/blob/main/transformer_engine/pytorch/module/base.py#L257C68-L257C86 is not defined when if num_domains > 1.
@denera denera linked a pull request Nov 2, 2024 that will close this issue
[PyTorch] Missing intra-domain ranks list when initializing Userbuffers with data parallelism #1305
Merged
13 tasks
@denera
Copy link
Collaborator

denera commented Nov 2, 2024

Thanks! This was internally reported earlier today as well and PR #1305 should fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@denera denera

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@denera @erhoo82