From 84b2f0e5a23a6521c1a6b0d5460914ff5690201b Mon Sep 17 00:00:00 2001 From: Ettore Pasquini Date: Mon, 5 Feb 2024 12:01:16 -0800 Subject: [PATCH] Fix GitHub CI warnings for using set-output --- .github/workflows/archive-and-upload.yml | 1 + Simplified.xcodeproj/project.pbxproj | 8 ++++---- scripts/detect-app-to-build.sh | 6 +++--- 3 files changed, 8 insertions(+), 7 deletions(-) diff --git a/.github/workflows/archive-and-upload.yml b/.github/workflows/archive-and-upload.yml index bd16e3334..f443658dd 100644 --- a/.github/workflows/archive-and-upload.yml +++ b/.github/workflows/archive-and-upload.yml @@ -5,6 +5,7 @@ on: - develop - release/** - feature/** + - IOS-631/publicationBaseURL-crash jobs: version-check: runs-on: macOS-13 diff --git a/Simplified.xcodeproj/project.pbxproj b/Simplified.xcodeproj/project.pbxproj index 35678def3..7053658dd 100644 --- a/Simplified.xcodeproj/project.pbxproj +++ b/Simplified.xcodeproj/project.pbxproj @@ -5014,7 +5014,7 @@ CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES_ERROR; CODE_SIGN_ENTITLEMENTS = Simplified/SimplyE.entitlements; CODE_SIGN_IDENTITY = "iPhone Developer"; - CURRENT_PROJECT_VERSION = 4; + CURRENT_PROJECT_VERSION = 0; DEVELOPMENT_TEAM = 7262U6ST2R; "EXCLUDED_ARCHS[sdk=iphonesimulator*]" = arm64; GCC_PRECOMPILE_PREFIX_HEADER = YES; @@ -5034,7 +5034,7 @@ "$(inherited)", "@executable_path/Frameworks", ); - MARKETING_VERSION = 3.9.5; + MARKETING_VERSION = 3.9.6; OTHER_LDFLAGS = ( "$(inherited)", "-ld_classic", @@ -5068,7 +5068,7 @@ CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES_ERROR; CODE_SIGN_ENTITLEMENTS = Simplified/SimplyE.entitlements; CODE_SIGN_IDENTITY = "iPhone Distribution"; - CURRENT_PROJECT_VERSION = 4; + CURRENT_PROJECT_VERSION = 0; DEVELOPMENT_TEAM = 7262U6ST2R; GCC_PRECOMPILE_PREFIX_HEADER = YES; GCC_PREFIX_HEADER = "Simplified/AppInfrastructure/Simplified-Prefix.pch"; @@ -5087,7 +5087,7 @@ "$(inherited)", "@executable_path/Frameworks", ); - MARKETING_VERSION = 3.9.5; + MARKETING_VERSION = 3.9.6; OTHER_LDFLAGS = ( "$(inherited)", "-ld_classic", diff --git a/scripts/detect-app-to-build.sh b/scripts/detect-app-to-build.sh index fb8c5aeef..043899e00 100755 --- a/scripts/detect-app-to-build.sh +++ b/scripts/detect-app-to-build.sh @@ -42,6 +42,6 @@ echo "** Version / build number changes **" echo "SimplyE: ($SIMPLYE_CHANGED)" echo "Open eBooks: ($OPENEBOOKS_CHANGED)" -echo "::set-output name=simplye_changed::$SIMPLYE_CHANGED" -echo "::set-output name=openebooks_changed::$OPENEBOOKS_CHANGED" - +# make values accessible to GitHub workflows +echo "simplye_changed=$SIMPLYE_CHANGED" >> $GITHUB_OUTPUT +echo "openebooks_changed=$OPENEBOOKS_CHANGED" >> $GITHUB_OUTPUT