Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the missing typecheck and normalization cases #60

Closed
9 of 12 tasks
Nadrieril opened this issue Apr 12, 2019 · 2 comments
Closed
9 of 12 tasks

Implement the missing typecheck and normalization cases #60

Nadrieril opened this issue Apr 12, 2019 · 2 comments
Labels
good first issue Good for newcomers

Comments

@Nadrieril
Copy link
Owner

Nadrieril commented Apr 12, 2019 •
edited
Loading

Some examples that should be very straightforward:

  • Integer/show
  • Natural/show
  • Double/show
  • Natural/toInteger

More involved:

  • #, aka ListAppend
  • Text/show
  • //\\, aka CombineTypes and RecursiveRecordTypeMerge
  • /\, aka Combine and RecursiveRecordMerge
  • //, aka Prefer and RightBiasedRecordMerge
  • record projection (record.{ x, y, z })
  • union constructor selection (union.x)
  • text interpolation

The full list of missing cases can be found in the commented tests in normalize.rs and typecheck.rs. Note that since imports are automatically typechecked, implementing only the normalization part may give you type errors.
See also #77
@Nadrieril Nadrieril added the good first issue Good for newcomers label Apr 12, 2019
@Nadrieril Nadrieril changed the title Implement some of the missing typecheck and normalization cases Implement the missing typecheck and normalization cases Apr 12, 2019
@Nadrieril Nadrieril pinned this issue Apr 12, 2019
@Nadrieril
Copy link
Owner Author

Nadrieril commented Apr 13, 2019 •
edited
Loading

Note: the master branch moves rather quickly. If master has advanced and broken your code, you can still submit a PR and I'll help you fix it.

@Nadrieril Nadrieril unpinned this issue Apr 26, 2019
@Nadrieril
Copy link
Owner Author

Closing in favor of #77

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Nadrieril