Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some DB stuff #413

Merged
merged 4 commits into from
Nov 15, 2024
Merged

Fix some DB stuff #413

merged 4 commits into from
Nov 15, 2024

Conversation

simonhamp
Copy link
Member

Off the back of #408, some other issues came to light.

  • native:migrate call doesn't work inside the service provider due to the command not actually being resolved yet
  • Configuring WAL mode only makes sense if we definitely have a DB to run those statements against
  • When removing the database (using native:migrate:fresh), we should clean up the SQLite WAL-mode files
  • Bonus: the exception handler is redundant and shouldn't run when we're not in a running NativePHP app context

@simonhamp simonhamp mentioned this pull request Nov 15, 2024
Closed
@simonhamp simonhamp merged commit a3bd955 into main Nov 15, 2024
2 of 23 checks passed
@simonhamp simonhamp deleted the fix/db-stuff branch November 15, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@simonhamp