Improvements to window test doubles #426
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing some work left from #422
@simonhamp there were some quirky HTTP client issues which I discovered once I took it for a spin in a real test suite for an app I'm working on. Fixed most of them, but we still need an HTTP fake to make it play nice. I was torn as to whether the test double should do the HTTP faking, or leave it up to the user. I opted for the latter. This can be documented.
Here's a general happy-path test snippet, if you'd like to update the docs with a testing section at some point:
The mocks are a little disgusting, so perhaps a test double for the window implementation – not just the manager – would be helpful in the future. I'll release more of these as I come across the use case.