Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatic retry on duplicate AMI name via decorator fails due to improper exception handling #252

Open
kvick opened this issue Mar 26, 2017 · 0 comments
Open

Automatic retry on duplicate AMI name via decorator fails due to improper exception handling #252

kvick opened this issue Mar 26, 2017 · 0 comments

Comments

@kvick
Copy link
Contributor

kvick commented Mar 26, 2017

During the refactor of _register_image to support ENA networking, the exception handling wasn't properly addressed as boto3 passes along the ClientError from botocore and the decorator is expecting EC2ResponseError which doesn't trigger the auto-incrementing name behavior.

The proposed change is to change the registration_retry decorator to use the ClientError vs EC2ResponseError.

Admittedly, this is not a common case, but we do see it typically due to (misconfigured) parallel bake pipelines.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kvick