From ea2ba4e63a8cf9de2b35c56a70b4eed957f208dd Mon Sep 17 00:00:00 2001
From: julienbrs <106234742+julienbrs@users.noreply.github.com>
Date: Thu, 16 Nov 2023 09:56:15 +0100
Subject: [PATCH] Test storing custom types (#112)

* feat: Tests for storing_custom_types

* nit

* fix: using embed_v0

* fix: StoringCustomTypes tests

* nit: removing the get_person method

---------

Co-authored-by: julio4 <jules.doumeche@gmail.com>
---
 .../storing_custom_types/src/contract.cairo   | 38 +++++++++----------
 .../storing_custom_types/src/tests.cairo      | 32 +++++++++++++++-
 2 files changed, 50 insertions(+), 20 deletions(-)

diff --git a/listings/ch00-getting-started/storing_custom_types/src/contract.cairo b/listings/ch00-getting-started/storing_custom_types/src/contract.cairo
index 289a90f9..c6bf1ea0 100644
--- a/listings/ch00-getting-started/storing_custom_types/src/contract.cairo
+++ b/listings/ch00-getting-started/storing_custom_types/src/contract.cairo
@@ -1,29 +1,29 @@
+#[starknet::interface]
+trait IStoringCustomType<TContractState> {
+    fn set_person(ref self: TContractState, person: Person);
+}
+
+// Deriving the starknet::Store trait
+// allows us to store the `Person` struct in the contract's storage.
+#[derive(Drop, Serde, Copy, starknet::Store)]
+struct Person {
+    age: u8,
+    name: felt252
+}
+
 #[starknet::contract]
 mod StoringCustomType {
+    use super::Person;
+
     #[storage]
     struct Storage {
         person: Person
     }
 
-    // Deriving the starknet::Store trait
-    // allows us to store the `Person` struct in the contract's storage.
-    #[derive(Drop, starknet::Store)]
-    struct Person {
-        age: u8,
-        name: felt252
-    }
-
-    #[abi(per_item)]
-    #[generate_trait]
-    impl StoringCustomType of IStoringCustomType {
-        #[external(v0)]
-        fn set_person(ref self: ContractState) {
-            self.person.write(Person { age: 10, name: 'Joe' });
-        }
-
-        #[external(v0)]
-        fn get_person(self: @ContractState) {
-            self.person.read();
+    #[abi(embed_v0)]
+    impl StoringCustomType of super::IStoringCustomType<ContractState> {
+        fn set_person(ref self: ContractState, person: Person) {
+            self.person.write(person);
         }
     }
 }
diff --git a/listings/ch00-getting-started/storing_custom_types/src/tests.cairo b/listings/ch00-getting-started/storing_custom_types/src/tests.cairo
index 361dba07..7c0b4293 100644
--- a/listings/ch00-getting-started/storing_custom_types/src/tests.cairo
+++ b/listings/ch00-getting-started/storing_custom_types/src/tests.cairo
@@ -1,2 +1,32 @@
-mod tests { // TODO
+// The purpose of these tests is to demonstrate the capability to store custom types in the contract's state.
+
+mod tests {
+    use storing_custom_types::{
+        contract::{
+            IStoringCustomType, StoringCustomType,
+            StoringCustomType::{Person, person::InternalContractMemberStateTrait}
+        }
+    };
+
+    use starknet::{ContractAddress, contract_address_const, testing::{set_contract_address}};
+
+    fn setup() -> StoringCustomType::ContractState {
+        let mut state = StoringCustomType::contract_state_for_testing();
+        let contract_address = contract_address_const::<0x1>();
+        set_contract_address(contract_address);
+        state
+    }
+
+    #[test]
+    #[available_gas(2000000000)]
+    fn can_call_set_person() {
+        let mut state = setup();
+        let person = Person { age: 10, name: 'Joe' };
+
+        state.set_person(person);
+        let read_person = state.person.read();
+
+        assert(person.age == read_person.age, 'wrong age');
+        assert(person.name == read_person.name, 'wrong name');
+    }
 }