-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add healthcheck to operator container #240
Comments
Once we do this, then the test from #244 should be changed to check the health of the operator services directly |
I'm unsure whether we should include a health check inside the container. I don't see any benefits from it. Moving the logic from the health container to the operator container wouldn't change anything. Perhaps we should consider a more sophisticated health check algorithm. |
Hey, this is mostly a best practices thing. The container itself should have a general way for you to check if it`s healthy or not - you can always override it, but overall a separate service is not ideal. We did have a separate service before since our container had only the bare minimum infra. |
We have an external healthcheck in the docker compose environment, but it'd be nice to have it directly in the image.
The text was updated successfully, but these errors were encountered: