Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle checkpoint submission failure #245

Open
Hyodar opened this issue Jun 6, 2024 · 0 comments
Open

Properly handle checkpoint submission failure #245

Hyodar opened this issue Jun 6, 2024 · 0 comments

Comments

@Hyodar
Copy link
Contributor

Hyodar commented Jun 6, 2024

Very rarely it seems like we get an error while sending a checkpoint task, even though it does send the transaction. For example, from testnet-0:

{"level":"error","ts":1717659728.592507,"caller":"aggregator/aggregator.go:406","msg":"Aggregator failed to send checkpoint","err":"send: failed to estimate gas and nonce\nsend: tx 0x1e3f8d9fc8484c2ff79b7534fea63e69790c6141d0bf9defcb7c24b5630fb64b failed.: FeeTooLowToCompete","stacktrace":"github.com/NethermindEth/near-sffl/aggregator.(*Aggregator).sendNewCheckpointTask\n\t/app/aggregator/aggregator.go:406"}

Still, the transaction was indeed sent and operators did try answering to it, but as we exit early when sending the checkpoint tx fails, the task was not initialized. This looks like an RPC issue - maybe we need to set more sensible timeouts or retries?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant