Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic text checks for JSON (to catch some typos) #856

Open
sboosali opened this issue Dec 13, 2024 · 0 comments
Open

Add basic text checks for JSON (to catch some typos) #856

sboosali opened this issue Dec 13, 2024 · 0 comments

Comments

@sboosali
Copy link

sboosali commented Dec 13, 2024

Cards of certain subtypes always have specific rules-text (like Double/Triple/Priority/Terminal). The motivation is typos like #854.

Maybe we can add an "associated_text": field to card_subtypes.json, that is usable when testing card JSON. For example,

[

  {
    "id": "priority",
    "name": "Priority",
    "associated_text": [
      "Play only as your first [click]"
     ]
   },

  {
    "id": "double",
    "name": "Double",
    "associated_text": [
      "As an additional cost to play this event, spend [click]",
      "As an additional cost to play this operation, spend [click]"
     ]
   },

  {
    "id": "triple",
    "name": "Triple",
    "associated_text": [
      "As an additional cost to play this event, spend [click][click]",
      "As an additional cost to play this operation, spend [click][click]"
     ]
   },

  {
    "id": "terminal",
    "name": "Terminal",
    "associated_text": [
      "After you resolve this event, end your action phase.",
      "After you resolve this operation, end your action phase."
     ]
   },

  
]

The value could be an string-array of possibile lines, or a regular expression (e.g. for (event|operation)), or something else.

@sboosali sboosali changed the title Add basic checks for JSON (to catch some typos) Add basic text checks for JSON (to catch some typos) Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant