Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove base_link from A Teia and Epiphany and memory_cost from runner ids. #791

Merged
merged 1 commit into from
Nov 25, 2023
Merged

Remove base_link from A Teia and Epiphany and memory_cost from runner ids. #791

merged 1 commit into from
Nov 25, 2023

Conversation

plural
Copy link
Collaborator

@plural plural commented Nov 25, 2023

No description provided.

@plural plural requested a review from distributive November 25, 2023 06:11
distributive
distributive approved these changes Nov 25, 2023
View reviewed changes
Copy link
Contributor

@distributive distributive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not store memory limits for Runner IDs? We probably should

@plural plural merged commit cd61b83 into NetrunnerDB:main Nov 25, 2023
1 check passed
@plural plural deleted the fix-tai-identities branch November 25, 2023 17:35
@plural
Copy link
Collaborator Author

plural commented Nov 25, 2023

Do we not store memory limits for Runner IDs? We probably should

we don't! I was surprised as well. I'll file an issue for it. We only have 1 ID that affects MU, but it's also the ID text, not a basic limit of 5 for Chaos Theory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@distributive distributive distributive approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@plural @distributive