Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebSocket messages max size 64KiB prevents sending e.g. images #248

Open
gsteinLTU opened this issue May 1, 2024 · 1 comment
Open

WebSocket messages max size 64KiB prevents sending e.g. images #248

gsteinLTU opened this issue May 1, 2024 · 1 comment

Comments

@gsteinLTU
Copy link
Member

gsteinLTU commented May 1, 2024

We think this might be from actix, but it's causing issues doing things like sending an image from a PhoneIoT VM project. We tested and the browser used could send larger messages with no issue in other applications, the message is successfully sent. No message (WS or NetsBlox) is received on the recipient client.

@dragazo
Copy link
Collaborator

dragazo commented May 2, 2024

The working theory is that this comment in actix-web implies continuations are not supported, which would force every ws message to be a single frame. Meanwhile the Codec constructor has a default max frame size of 64KB.

Ideally we could switch to a different WS lib that actually works, but a minimal hack would be just increasing the max frame size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants