Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case sensitive usernames #34

Closed
brollb opened this issue Jan 11, 2023 · 1 comment
Closed

Case sensitive usernames #34

brollb opened this issue Jan 11, 2023 · 1 comment

Comments

@brollb
Copy link
Collaborator

brollb commented Jan 11, 2023

Although case-insensitive usernames are probably the better option (#30), there is a bit more work to make them happen (switch to user IDs, renaming user support). For now, we should use case-sensitive usernames to preserve backwards compatibility and make migration easier.

@brollb
Copy link
Collaborator Author

brollb commented Jan 11, 2023

The main problem is that when migrating from the old system, we will get usernames with case differences. The current server converts everything to lowercase to make it case-insensitive but this will make accounts with capital letters unable to be logged into until a proper case-insensitive approach is taken (#31). However, that depends on a few other changes to make the migration from the old system work (mentioned above).

@brollb brollb closed this as completed in 2c527e0 Jan 13, 2023
brollb added a commit that referenced this issue Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant