Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log file handlers left open after rotation #63

Closed
Grumblesmith opened this issue May 22, 2018 · 5 comments
Closed

Log file handlers left open after rotation #63

Grumblesmith opened this issue May 22, 2018 · 5 comments
Assignees
@codytipton
Labels
bug minor

Comments

@Grumblesmith
Copy link

File handles are sometimes being left open for logs. Initial investigation indicated this is because all the agent processes are writing to the log file, and that concurrency isn't being handled well by the TimedRotatingFileHandler.
@Grumblesmith Grumblesmith added minor and removed major labels Jul 20, 2018
@TheConnMan
Copy link
Contributor

Looks related to this issue: http://thinlight.org/2011/08/10/python-logging-from-multiple-processes/

@TheConnMan
Copy link
Contributor

The logging handler we use is OOTB from Python. Also, the upstream Diamond project has not changed the timedrotating.py file at all.

As this is a minor, I recommend either opening an issue on the upstream Diamond project to try getting some more experienced eyes on it or using a new logging handler altogether.

@TheConnMan
Copy link
Contributor

We're going to install a pure Diamond agent and see if we get the same issue.

@TheConnMan
Copy link
Contributor

Issue opened on the Diamond project: python-diamond/Diamond#720

@Grumblesmith Grumblesmith changed the title Log file rotation issue Log file handlers left open after rotation Nov 6, 2018
This was referenced Nov 29, 2018
Merged
Merged
Merged
codytipton added a commit that referenced this issue Nov 30, 2018
@codytipton
Merge pull request #93 from Netuitive/bugfix/concurrentlog
110a7c4 
Provide class ConcurrentRotatingFileHandler and import concurrent_log_handler before logging.FileConfig()

2nd of 3 PR's addressing #63
codytipton added a commit to Netuitive/omnibus-netuitive-agent that referenced this issue Nov 30, 2018
@codytipton
Merge pull request #105 from Netuitive/bugfix/logloss
934a295 
Make ConcurrentRotatingFileHandler the default in netuitive-agent.conf. 3rd of 3 PR's fixing Netuitive/netuitive-diamond#63
@codytipton codytipton self-assigned this Nov 30, 2018
@codytipton
Copy link
Collaborator

Fixed by Netuitive/omnibus-netuitive-agent@934a295

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codytipton codytipton

Labels
bug minor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@TheConnMan @Grumblesmith @codytipton