Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Deprecate +contrib #642

Open
2 tasks done
ehennestad opened this issue Nov 28, 2024 · 4 comments
Open
2 tasks done

[Feature]: Deprecate +contrib #642

ehennestad opened this issue Nov 28, 2024 · 4 comments
Labels
category: proposal discussion of proposed enhancements or new features status: need verification potentially solved, but needs verification

Comments

@ehennestad
Copy link
Collaborator

What would you like to see added to MatNWB?

Deprecate +contrib namespace and/or move it to separate repository like matnwb-third-party

Is your feature request related to a problem?

No response

What solution would you like?

See above

Do you have any interest in helping implement the feature?

Yes.

Code of Conduct

@ehennestad ehennestad added category: proposal discussion of proposed enhancements or new features status: need verification potentially solved, but needs verification labels Dec 9, 2024
@ehennestad
Copy link
Collaborator Author

@bendichter , What do you think?

@bendichter
Copy link
Contributor

I'd be fine with that as long as there are docs that point to it. I haven't touched these functions in years and they are pretty basic. I'm hesitant to go too far down this road though since it seems like that would just end duplicating a lot of the effort in NeuroConv, but it's nice to have something that can demonstrate basic ideas of reading and writing data.

@ehennestad
Copy link
Collaborator Author

The main motivation would be to deprecate it from matnwb, but not to delete it completely as it might be still useful for people.

since it seems like that would just end duplicating a lot of the effort in NeuroConv

Agreed, it can even be explicitly stated that NeuroConv is the recommended library for conversion of neurodata.

@bendichter
Copy link
Contributor

Sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: proposal discussion of proposed enhancements or new features status: need verification potentially solved, but needs verification
Projects
None yet
Development

No branches or pull requests

2 participants