Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit User doesn't enforce email formatted emails, login does #4168

Open
jonfriesen opened this issue Nov 16, 2024 · 0 comments
Open

Edit User doesn't enforce email formatted emails, login does #4168

jonfriesen opened this issue Nov 16, 2024 · 0 comments
Labels

Comments

@jonfriesen
Copy link

Checklist

  • Have you pulled and found the error with jc21/nginx-proxy-manager:latest docker image?
    • Yes / No
  • Are you sure you're not using someone else's docker image?
    • Yes / No
  • Have you searched for similar issues (both open and closed)?
    • Yes / No

Describe the bug

Email formatted content is not required in the Edit User email input field. This means a user can enter a non-email value (for example, just their name). However, the login page does enforce an email formatted value blocking the user from logging in.

Nginx Proxy Manager Version

v2.12.1

To Reproduce

  1. Login
  2. Edit the users email to be a non-email, for example joe
  3. Logout
  4. Try to login

Note: if you find yourself in this situation, in a chrome browser right click and inspect the email field on the login page, then edit the type="email" attribute on the email form to be type="text" and login.

Expected behavior

I think there are two directions here:

  1. Update the login key to be any value (not email specific)
  2. Enforce the email format in the Edit User page

Either are acceptable IMO.

Screenshots

image image

Operating System

TrueNAS Scale 24.10 deployed with Docker, using the community chart.

Additional context

@jonfriesen jonfriesen added the bug label Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant