Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why are Guzzle http_errors disabled? #100

Open
DrDelay opened this issue Aug 12, 2016 · 3 comments
Open

Why are Guzzle http_errors disabled? #100

DrDelay opened this issue Aug 12, 2016 · 3 comments

Comments

@DrDelay
Copy link
Collaborator

DrDelay commented Aug 12, 2016

I asked this here and decided to open an own issue for it.

They are set to false in the Client and RequestHandler.

I don't really see the reason, especially since the behavior got basically re-implemented in 01cb790.

@Ni42
Copy link
Collaborator

Ni42 commented Aug 12, 2016

Oh, yeah, the nicer way would be to let Guzzle throw them instead of doing that status code check :)

@NicklasWallgren
Copy link
Owner

Old habits die hard I guess ;) No real reason really, better readability maybe.

@DrDelay
Copy link
Collaborator Author

DrDelay commented Aug 14, 2016

To inspect/debug errors (e.g. #105) it would be more useful to just let Guzzle handle it I think.

So if there is no real reason why not I'll start looking for what would have to change (removing the then-redundant self-implemented checks).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants