Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Research into swapping Zend\Diactoros\ServerRequest with Slim\Http\Request #24

Open
NigelGreenway opened this issue Jun 14, 2017 · 0 comments

Comments

@NigelGreenway
Copy link
Owner

It seems like this is the better solution as it is all native to SlimPHP, but is this the right right to go, as they both use the PSR interface it should be simple to swap out and remove the non-required dependancy of Zend\Diactoros?

$slimRequest = new Request(
    $request->getMethod(),
    Uri::createFromString(
         $request->getPath() . '?' . http_build_query($request->getQueryParams())
    ),
    new Headers($request->getHeaders()),
    SlimCookies::parseHeader($request->getHeader('Cookie')),
    [],
    $stream,
    []
);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant