Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are input .drvs replaced by the same algorithm as output .drvs? #245

Open
noamraph opened this issue Apr 24, 2024 · 0 comments
Open

Are input .drvs replaced by the same algorithm as output .drvs? #245

noamraph opened this issue Apr 24, 2024 · 0 comments

Comments

@noamraph
Copy link
Contributor

I read this in chapter 18:

In case the .drv has input derivations, that is it references other .drv, then such .drv paths are replaced by this same algorithm which returns a hash.

Just above this, the text describes how in order to calculate the hash of the derivation, output derivations are replaced with an empty string. I don't believe this is done for input derivations, as I'm pretty sure they should be already known when calculating the hash of a derivation.

Am I correct? If so, I suggest to change the paragraph to something like:

In case the .drv has input derivations, that is, it references other .drvs, there is no need to replace their path with an empty string, since their hash is calculated beforehand, using the algorithm described here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant