From e67b1b3e4d44665042088f3ae5dffce8bf1ac7eb Mon Sep 17 00:00:00 2001
From: Johannes Kirschbauer <hsjobeki@gmail.com>
Date: Wed, 3 Jul 2024 01:33:00 +0200
Subject: [PATCH] fix: some types of InlineSVG (#1497)

- extend the Intrinsic svg html attributes

instead of explicit type cast, which is more unsafe

- Add `as const`

Which creates more narrow type unions for e.g the color "lightblue" |
"orange" | "green" instead of "string" for the non-const expression
---
 src/components/util/InlineSVG.astro | 10 +++++++---
 src/pages/learn.astro               |  4 ++--
 2 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/src/components/util/InlineSVG.astro b/src/components/util/InlineSVG.astro
index ca78d3fd29..75baf64e79 100644
--- a/src/components/util/InlineSVG.astro
+++ b/src/components/util/InlineSVG.astro
@@ -2,8 +2,9 @@
 import { parse } from "node-html-parser";
 // svgo is a peer dependency of astro-icon
 import { optimize } from "svgo";
+import type { Attributes } from "node-html-parser/dist/nodes/html";
 
-export interface Props {
+export interface Props extends Attributes {
   src: string;
 }
 
@@ -12,8 +13,11 @@ interface SVGFile {
   file: string;
 }
 
-const { src, ...attributes } = Astro.props as Props;
-const res = import.meta.glob("/src/**/*.svg", { eager: true, query: "?raw" });
+const { src, ...attributes } = Astro.props;
+const res = import.meta.glob("/src/**/*.svg", {
+  eager: true,
+  query: "?raw",
+}) as Record<string, SVGFile>;
 
 if (!(src in res)) {
   throw new Error(`${src} not found`);
diff --git a/src/pages/learn.astro b/src/pages/learn.astro
index 769623c480..d4e3924ac2 100644
--- a/src/pages/learn.astro
+++ b/src/pages/learn.astro
@@ -28,7 +28,7 @@ const learningFeatures = [
     color: "lightblue",
     url: "/guides/how-nix-works",
   },
-];
+] as const;
 
 const learningResources = [
   {
@@ -51,7 +51,7 @@ const learningResources = [
     url: "/guides/nix-pills",
     buttonText: "Take the Pills",
   },
-];
+] as const;
 ---
 
 <Layout title="Learn Nix | Nix & NixOS">