Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reflected spectrum encoder #214

Open
wsnoble opened this issue Jul 19, 2023 · 2 comments
Open

Add reflected spectrum encoder #214

wsnoble opened this issue Jul 19, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@wsnoble
Copy link
Contributor

wsnoble commented Jul 19, 2023

Try adding a second spectrum with (m_pre - m_i)/z_i as the m/z values, a la the Panda paper.

@wsnoble wsnoble added the enhancement New feature or request label Jul 19, 2023
@bittremieux
Copy link
Collaborator

Should we provide a second spectrum as input, or just add the reflected peaks to the original input spectrum?

@wsnoble
Copy link
Contributor Author

wsnoble commented Jul 23, 2023

No, we should start by mimicking what is done in Pandanovo, which is to create a separate encoder for the reflected spectrum. It may be worth also trying the simpler approach subsequently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants