Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible missing data of benchmarking supervised performance #36

Open
Eikor opened this issue Jun 19, 2024 · 1 comment
Open

Possible missing data of benchmarking supervised performance #36

Eikor opened this issue Jun 19, 2024 · 1 comment

Comments

@Eikor
Copy link

Eikor commented Jun 19, 2024

Hi, thank you for such fundamental work for the computational bio community!

I am interested in evaluating the model's performance in a supervised setting.
I have download the DMS_supervised_substitutions_scores.csv and run the script provide in scripts/scoring_DMS_supervised/performance_substitutions.sh, I modified the --input_scoring_file as DMS_supervised_substitutions_scores.csv and --DMS_reference_file_path as DMS_substitutions.csv. However, there is an error occurred in

old_ids = ref_df["Old_DMS_ID"].unique()
, I wonder am I passing the wrong reference file or this script needs to be updated with current reference file?

Thanks!

@pascalnotin
Copy link
Contributor

Hi @Eikor - thank you for your question!

The error you are experiencing is due to a change in naming conventions for certain of the files (also discussed here), and we were indeed using a different reference file (similar to this one but with a mapping to the old IDs as well) when running this particular script internally. We will fix these issues in a new release as soon as possible.
In the meantime, you may use the performance files here which are the ones you would obtain by running this script.

Kind regards,
Pascal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants