Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agreement Rebate - Issue in behaviour #36

Open
SIC-brunorocha opened this issue May 31, 2024 · 2 comments
Open

Agreement Rebate - Issue in behaviour #36

SIC-brunorocha opened this issue May 31, 2024 · 2 comments
Labels

Comments

@SIC-brunorocha
Copy link

Disclaimer

I believe I'm reporting a bug, based on what I suppose should be the behaviour of the module.
The module documentation did not explain this, so I'm reporting so it can be addressed.

Module

agreement_rebate

Describe the bug

If a settlement is already made, the next does not take into the consideration that amount already returned to the client

To Reproduce

V16

Steps to reproduce the behaviour:
1.Define sections
exemple: 0 --> 1k€ get 5% ; them 1001---> 5k€ get 10%, 10k gets 20%
2.Start invoicing the client
3. The client ends hitting the 1000 mark and now as for example, 50 € to receive based on the rebate made.
4. Settlement made and keep invoicing
5. The next mark is achieved, and we invoiced 11.5k to the client, after rebase it gets 3400 € in favour of the client.
6. [Bug] - The previous 50€ are not take into consideration

Expected behaviour

  1. Recalculate based on the settlement already made
@SIC-brunorocha
Copy link
Author

Screenshot_2
Excel with a case study I used

@pedrobaeza
Copy link
Member

The system is not prepared right now to do rebates over the same period, and that's why you get this. It will be simply to exclude the refund invoices coming from rebates, and it doesn't hurt any of the possible flows. Please propose a PR with that patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants