Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check plots for protection against ggplot change to legend rendering #143

Closed
zackarno opened this issue Jun 6, 2024 · 5 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@zackarno
Copy link
Collaborator

zackarno commented Jun 6, 2024

just spent an hour trouble shooting why 2 plots in a different repo weren't working as expected.

Therefore, flagging here -- as it could effect any plot aesthetic where we want a legend class to show even if not in the data set (i.e dropped)

tidyverse/ggplot2#5728

@zackarno zackarno added the enhancement New feature or request label Jun 6, 2024
@zackarno zackarno added this to the public-release milestone Jun 6, 2024
@caldwellst
Copy link
Collaborator

caldwellst commented Jun 6, 2024

Have a look through the plotting functions. The only instance where we use factors and legends should be #136. What an annoying change!!

@caldwellst
Copy link
Collaborator

Addressed in #146.

@zackarno
Copy link
Collaborator Author

zackarno commented Jun 12, 2024

re-opening due to #165

@zackarno zackarno reopened this Jun 12, 2024
@caldwellst
Copy link
Collaborator

This is not related to #165. That is because we have two separate geoms in the legend, and we would rather consolidate into 1.

@zackarno
Copy link
Collaborator Author

it is related as the IPC levels are getting dropped

@zackarno zackarno reopened this Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants