Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proprer fix for check_records #958

Closed
Halbaroth opened this issue Nov 21, 2023 · 1 comment
Closed

Proprer fix for check_records #958

Halbaroth opened this issue Nov 21, 2023 · 1 comment
Assignees
@Halbaroth

Comments

@Halbaroth
Copy link
Collaborator

This issue is a remainder to apply a proper fix on check_records after merging #952.
The current hotfix will be irrelevant as soon as we use Expr.t to represent model values.
@Halbaroth Halbaroth self-assigned this Nov 21, 2023
@Halbaroth Halbaroth mentioned this issue Nov 21, 2023
Merged
@Halbaroth
Copy link
Collaborator Author

This issue isn't relevant anymore as we produce model terms directly from the semantic values of the record theory, so there is no check_records anymore ;)

See #925

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Halbaroth Halbaroth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Halbaroth