Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bug 923: generated modules init/clear unused decimal constants #115

Closed
wants to merge 2 commits into from

Conversation

ddeclerck
Copy link
Contributor

@ddeclerck ddeclerck commented Oct 17, 2023

That should address https://sourceforge.net/p/gnucobol/bugs/923/.

Passes all of the testsuite.

@ddeclerck ddeclerck requested a review from GitMensch October 17, 2023 11:31
Copy link
Collaborator

@GitMensch GitMensch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this well done PR.

There are only minor adjustments needed. Once there is a "go" for committing to svn ("soon"), I suggest to first commit this, then the other PR of yours.

cobc/ChangeLog Outdated Show resolved Hide resolved
cobc/ChangeLog Outdated Show resolved Hide resolved
cobc/codegen.c Outdated Show resolved Hide resolved
cobc/codegen.c Show resolved Hide resolved
cobc/codegen.c Outdated Show resolved Hide resolved
cobc/codegen.c Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #115 (909c3cc) into gcos4gnucobol-3.x (c0d64ad) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@                Coverage Diff                 @@
##           gcos4gnucobol-3.x     #115   +/-   ##
==================================================
  Coverage              65.74%   65.74%           
==================================================
  Files                     32       32           
  Lines                  59092    59099    +7     
  Branches               15575    15573    -2     
==================================================
+ Hits                   38849    38856    +7     
  Misses                 14262    14262           
  Partials                5981     5981           
Files Coverage Δ
cobc/codegen.c 76.01% <100.00%> (+0.02%) ⬆️
cobc/typeck.c 65.28% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@GitMensch GitMensch changed the title Fix bug 923 Fix Bug 923: generated modules init/clear unused decimal constants Oct 19, 2023
@ddeclerck ddeclerck closed this Jan 22, 2024
@ddeclerck ddeclerck deleted the fix_923 branch July 15, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants