New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Ogre::String and remove wchar_t related macros #4

Open

kPYKx7Ddw4n1aIKZ opened this issue Aug 13, 2018 · 1 comment

Collaborator

kPYKx7Ddw4n1aIKZ commented Aug 13, 2018

In the code every string constant is wrapped in the _T() macro.
According to (link), this is used for Unicode support.

Apart from that i've never seen this macro in any other source and if I understand it right, OGRE_WCHAR_T_STRINGS is used for this purpose, too.

Would it be useful to remove all the _T() macros (using Regex maybe) and use Ogre::String everywhere?

Member

paroj commented Aug 20, 2018

Would it be useful to remove all the _T() macros (using Regex maybe) and use Ogre::String everywhere?

at some later point maybe, as the priority right now should be to get the main functionality running again. #8

For now we can easily make _T() a noop, like it already is on linux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment