lua: update lua crate with better header copying #12129
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update lua crate to 0.1.0-alpha.5. This update will rewrite the headers if the env var SURICATA_LUA_SYS_HEADER_DST changes. This fixes the issue where the headers may not be written.
The cause is that Rust dependencies are cached, and if your editor is using rust-analyzer, it might cache the built without this var being set, so these headers are not available to Suricata. This crate update forces the re-run of the Lua build.rs if this env var changes, fixing this issue.
This new Lua crate is also smarter about writing out the headers, don't overwrite if the destination appears to be the same as the source, as this can force subsequent invocations of make to rebuild the C source.
Fixes this issue in PR #12104:
make <build>
andmake install
, which smarter build systems can detect, if there are vars that matter to the build. In this case it was the library search path.