Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make integer/floating point types configurable through cmake #161

Open
superwhiskers opened this issue Jun 12, 2024 · 0 comments
Open

make integer/floating point types configurable through cmake #161

superwhiskers opened this issue Jun 12, 2024 · 0 comments
Assignees
Labels
cmake enhancement New feature or request

Comments

@superwhiskers
Copy link
Collaborator

overview

some workflows may benefit from wider integer or floating point types. these should be configurable through options passed to cmake, which should correctly force-disable things currently incompatible with certain types (such as some of the hip and probably cuda code). additionally, they should set the corresponding type aliases (real_type/index_type) in resolve/Common.hpp and resolve/lusol/lusol_precision.f90

additional notes

  • the hip/cuda code could be modified to be compatible with wider integer types (in the event native support is not possible) by partitioning the job, probably
  • an instance in which another similar project has done this sort of thing can be found here1

Footnotes

  1. https://github.com/LLNL/sundials/blob/main/cmake/SundialsBuildOptionsPre.cmake#L29-L36

@superwhiskers superwhiskers added the enhancement New feature or request label Jun 12, 2024
@pelesh pelesh added the cmake label Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmake enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants